* Add initial classes * Add TelemetryProviders * Add new NodeCountService.cs and NodeTelemetryProvider * Add data contract attribute to UsageInformation Otherwise it wont serialize correctly * Implement more providers * Fix builders and propertyEditorTelemetry * Add MediaTelemetryProvider * Add MediaTelemetryProvider * Fix doubling of media telemetry * Move contentCount from NodeCountTelemetryProvider and move to ContentTelemetryProvider * Revert ContentTelemetryProvider changes * Add detailed information to TelemetryService * Add integration tests * Add more tests and todos for tests * Fix stylecop warnings * Use yield return instead of instantiating local list * Implement Macro test * Inject interface instead of implementation in TelemetryService * Fix TelemetryServiceTests.cs * Implement media tests * Implement propertyTypeTests * Implement constants instead of hardcoded strings * Add SystemInformationTelemetryProvider * Use SystemInformationTableDataProvider in UserDataService * Implement more properties * Add UsageInformation * Replace UserDataService with SystemInformationTelemetryProvider * Undo changes to UserDataService and obsolete it * Remove ISystemInformationTableDataProvider * Register SystemInformationTelemetryProvider as telemetry provider * Use constants for telemetry names * Make UserDataServiceTests test SystemInformationTelemetryProvider instead * Update UserDataServiceTests to cover new data * Add unit tests * Add integration test testing expected data is returned * Implement Analytics dashboard * Improve assertion message * Add text and styling to analyticspage * Rename consent to analytic * implement save button for consent level * Implement save button * Fix system information test * Add TelemetryResource * Move telemetry providers to infrastructure * Add database provider to system information * Set startvalue for slider * Fix unit tests * Implement MetricsConsentService using KeyValueService * Return void hen setting the telemetry level * fix startposition when not reloading * Add a couple tests * Update src/Umbraco.Core/Services/MetricsConsentService.cs * Rename ConsentLevel.cs * Use direct Enum instead of parsing * rename consent resource * add lazy database * refactor slider * Implement ng-if and propers pips * Make classes internal * Fix slider not loading when navigating to tab * Add telemetry level check to TelemetryService.cs * Add Consent for analytics text * Fix build errors for unit tests * Fix TelemetryServiceTests * revert package-lock.json * Fix integration test * Update slider * Update TelemetryService.cs * Apply suggestions from code review Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk> Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>
136 lines
5.8 KiB
C#
136 lines
5.8 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core.Configuration;
|
|
using Umbraco.Cms.Core.Manifest;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Semver;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Core.Telemetry;
|
|
|
|
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Telemetry
|
|
{
|
|
[TestFixture]
|
|
public class TelemetryServiceTests
|
|
{
|
|
[Test]
|
|
public void UsesGetOrCreateSiteId()
|
|
{
|
|
var version = CreateUmbracoVersion(9, 3, 1);
|
|
var siteIdentifierServiceMock = new Mock<ISiteIdentifierService>();
|
|
var usageInformationServiceMock = new Mock<IUsageInformationService>();
|
|
var sut = new TelemetryService(Mock.Of<IManifestParser>(), version, siteIdentifierServiceMock.Object, usageInformationServiceMock.Object, Mock.Of<IMetricsConsentService>());
|
|
Guid guid;
|
|
|
|
var result = sut.TryGetTelemetryReportData(out var telemetryReportData);
|
|
siteIdentifierServiceMock.Verify(x => x.TryGetOrCreateSiteIdentifier(out guid), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public void SkipsIfCantGetOrCreateId()
|
|
{
|
|
var version = CreateUmbracoVersion(9, 3, 1);
|
|
var sut = new TelemetryService(Mock.Of<IManifestParser>(), version, createSiteIdentifierService(false), Mock.Of<IUsageInformationService>(), Mock.Of<IMetricsConsentService>());
|
|
|
|
var result = sut.TryGetTelemetryReportData(out var telemetry);
|
|
|
|
Assert.IsFalse(result);
|
|
Assert.IsNull(telemetry);
|
|
}
|
|
|
|
[Test]
|
|
public void ReturnsSemanticVersionWithoutBuild()
|
|
{
|
|
var version = CreateUmbracoVersion(9, 1, 1, "-rc", "-ad2f4k2d");
|
|
|
|
var sut = new TelemetryService(Mock.Of<IManifestParser>(), version, createSiteIdentifierService(), Mock.Of<IUsageInformationService>(), Mock.Of<IMetricsConsentService>());
|
|
|
|
var result = sut.TryGetTelemetryReportData(out var telemetry);
|
|
|
|
Assert.IsTrue(result);
|
|
Assert.AreEqual("9.1.1-rc", telemetry.Version);
|
|
}
|
|
|
|
[Test]
|
|
public void CanGatherPackageTelemetry()
|
|
{
|
|
var version = CreateUmbracoVersion(9, 1, 1);
|
|
var versionPackageName = "VersionPackage";
|
|
var packageVersion = "1.0.0";
|
|
var noVersionPackageName = "NoVersionPackage";
|
|
PackageManifest[] manifests =
|
|
{
|
|
new () { PackageName = versionPackageName, Version = packageVersion },
|
|
new () { PackageName = noVersionPackageName }
|
|
};
|
|
var manifestParser = CreateManifestParser(manifests);
|
|
var metricsConsentService = new Mock<IMetricsConsentService>();
|
|
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Basic);
|
|
var sut = new TelemetryService(manifestParser, version, createSiteIdentifierService(), Mock.Of<IUsageInformationService>(), metricsConsentService.Object);
|
|
|
|
var success = sut.TryGetTelemetryReportData(out var telemetry);
|
|
|
|
Assert.IsTrue(success);
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.AreEqual(2, telemetry.Packages.Count());
|
|
var versionPackage = telemetry.Packages.FirstOrDefault(x => x.Name == versionPackageName);
|
|
Assert.AreEqual(versionPackageName, versionPackage.Name);
|
|
Assert.AreEqual(packageVersion, versionPackage.Version);
|
|
|
|
var noVersionPackage = telemetry.Packages.FirstOrDefault(x => x.Name == noVersionPackageName);
|
|
Assert.AreEqual(noVersionPackageName, noVersionPackage.Name);
|
|
Assert.AreEqual(string.Empty, noVersionPackage.Version);
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void RespectsAllowPackageTelemetry()
|
|
{
|
|
var version = CreateUmbracoVersion(9, 1, 1);
|
|
PackageManifest[] manifests =
|
|
{
|
|
new () { PackageName = "DoNotTrack", AllowPackageTelemetry = false },
|
|
new () { PackageName = "TrackingAllowed", AllowPackageTelemetry = true },
|
|
};
|
|
var manifestParser = CreateManifestParser(manifests);
|
|
var metricsConsentService = new Mock<IMetricsConsentService>();
|
|
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Basic);
|
|
var sut = new TelemetryService(manifestParser, version, createSiteIdentifierService(), Mock.Of<IUsageInformationService>(), metricsConsentService.Object);
|
|
|
|
var success = sut.TryGetTelemetryReportData(out var telemetry);
|
|
|
|
Assert.IsTrue(success);
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.AreEqual(1, telemetry.Packages.Count());
|
|
Assert.AreEqual("TrackingAllowed", telemetry.Packages.First().Name);
|
|
});
|
|
}
|
|
|
|
|
|
private IManifestParser CreateManifestParser(IEnumerable<PackageManifest> manifests)
|
|
{
|
|
var manifestParserMock = new Mock<IManifestParser>();
|
|
manifestParserMock.Setup(x => x.GetManifests()).Returns(manifests);
|
|
return manifestParserMock.Object;
|
|
}
|
|
|
|
private IUmbracoVersion CreateUmbracoVersion(int major, int minor, int patch, string prerelease = "", string build = "")
|
|
{
|
|
var version = new SemVersion(major, minor, patch, prerelease, build);
|
|
return Mock.Of<IUmbracoVersion>(x => x.SemanticVersion == version);
|
|
}
|
|
|
|
private ISiteIdentifierService createSiteIdentifierService(bool shouldSucceed = true)
|
|
{
|
|
var mock = new Mock<ISiteIdentifierService>();
|
|
var siteIdentifier = shouldSucceed ? Guid.NewGuid() : Guid.Empty;
|
|
mock.Setup(x => x.TryGetOrCreateSiteIdentifier(out siteIdentifier)).Returns(shouldSucceed);
|
|
return mock.Object;
|
|
}
|
|
}
|
|
}
|