* Persist and expose Umbraco system dates as UTC (#19705) * Updated persistence DTOs defining default dates to use UTC. * Remove ForceToUtc = false from all persistence DTO attributes (default when not specified is true). * Removed use of SpecifyKind setting dates to local. * Removed unnecessary Utc suffixes on properties. * Persist current date time with UtcNow. * Removed further necessary Utc suffixes and fixed failing unit tests. * Added migration for SQL server to update database date default constraints. * Added comment justifying not providing a migration for SQLite default date constraints. * Ensure UTC for datetimes created from persistence DTOs. * Ensure UTC when creating dates for published content rendering in Razor and outputting in delivery API. * Fixed migration SQL syntax. * Introduced AuditItemFactory for creating entries for the backoffice document history, so we can control the UTC setting on the retrieved persisted dates. * Ensured UTC dates are retrieved for document versions. * Ensured UTC is returned for backoffice display of last edited and published for variant content. * Fixed SQLite syntax for default current datetime. * Apply suggestions from code review Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com> * Further updates from code review. --------- Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com> * Migrate system dates from local server time to UTC (#19798) * Add settings for the migration. * Add migration and implement for SQL server. * Implement for SQLite. * Fixes from testing with SQL Server. * Fixes from testing with SQLite. * Code tidy. * Cleaned up usings. * Removed audit log date from conversion. * Removed webhook log date from conversion. * Updated update date initialization on saving dictionary items. * Updated filter on log queries. * Use timezone ID instead of system name to work cross-culture. --------- Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com>
247 lines
7.1 KiB
C#
247 lines
7.1 KiB
C#
// Copyright (c) Umbraco.
|
|
// See LICENSE for more details.
|
|
|
|
using System.Data.Common;
|
|
using System.Linq;
|
|
using Microsoft.Extensions.Logging;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core.Cache;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Infrastructure.Persistence.Repositories.Implement;
|
|
using Umbraco.Cms.Infrastructure.Scoping;
|
|
using Umbraco.Cms.Tests.Common.Testing;
|
|
using Umbraco.Cms.Tests.Integration.Testing;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories;
|
|
|
|
[TestFixture]
|
|
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest)]
|
|
internal sealed class ServerRegistrationRepositoryTest : UmbracoIntegrationTest
|
|
{
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
_appCaches = AppCaches.Disabled;
|
|
CreateTestData();
|
|
}
|
|
|
|
private AppCaches _appCaches;
|
|
|
|
private ServerRegistrationRepository CreateRepository(IScopeProvider provider) =>
|
|
new((IScopeAccessor)provider, LoggerFactory.CreateLogger<ServerRegistrationRepository>());
|
|
|
|
[Test]
|
|
public void Cannot_Add_Duplicate_Server_Identities()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
var server = new ServerRegistration("http://shazwazza.com", "COMPUTER1", DateTime.UtcNow);
|
|
|
|
Assert.That(() => repository.Save(server), Throws.InstanceOf<DbException>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Cannot_Update_To_Duplicate_Server_Identities()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
var server = repository.Get(1);
|
|
server.ServerIdentity = "COMPUTER2";
|
|
|
|
Assert.That(() => repository.Save(server), Throws.InstanceOf<DbException>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Instantiate_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Assert
|
|
Assert.That(repository, Is.Not.Null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Get_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var server = repository.Get(1);
|
|
|
|
// Assert
|
|
Assert.That(server, Is.Not.Null);
|
|
Assert.That(server.HasIdentity, Is.True);
|
|
Assert.That(server.ServerAddress, Is.EqualTo("http://localhost"));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_GetAll_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var servers = repository.GetMany();
|
|
|
|
// Assert
|
|
Assert.That(servers.Count(), Is.EqualTo(3));
|
|
}
|
|
}
|
|
|
|
// queries are not supported due to in-memory caching
|
|
//// [Test]
|
|
//// public void Can_Perform_GetByQuery_On_Repository()
|
|
//// {
|
|
//// // Arrange
|
|
//// var provider = ScopeProvider;
|
|
//// using (var unitOfWork = provider.GetUnitOfWork())
|
|
//// using (var repository = CreateRepository(provider))
|
|
//// {
|
|
//// // Act
|
|
//// var query = Query<IServerRegistration>.Builder.Where(x => x.ServerIdentity.ToUpper() == "COMPUTER3");
|
|
//// var result = repository.GetByQuery(query);
|
|
|
|
//// // Assert
|
|
//// Assert.AreEqual(1, result.Count());
|
|
//// }
|
|
//// }
|
|
|
|
//// [Test]
|
|
//// public void Can_Perform_Count_On_Repository()
|
|
//// {
|
|
//// // Arrange
|
|
//// var provider = ScopeProvider;
|
|
//// using (var unitOfWork = provider.GetUnitOfWork())
|
|
//// using (var repository = CreateRepository(provider))
|
|
//// {
|
|
//// // Act
|
|
//// var query = Query<IServerRegistration>.Builder.Where(x => x.ServerAddress.StartsWith("http://"));
|
|
//// int count = repository.Count(query);
|
|
|
|
//// // Assert
|
|
//// Assert.That(count, Is.EqualTo(2));
|
|
//// }
|
|
//// }
|
|
|
|
[Test]
|
|
public void Can_Perform_Add_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var server = new ServerRegistration("http://shazwazza.com", "COMPUTER4", DateTime.UtcNow);
|
|
repository.Save(server);
|
|
|
|
// Assert
|
|
Assert.That(server.HasIdentity, Is.True);
|
|
Assert.That(server.Id, Is.EqualTo(4)); // With 3 existing entries the Id should be 4
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Update_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var server = repository.Get(2);
|
|
server.ServerAddress = "https://umbraco.com";
|
|
server.IsActive = true;
|
|
|
|
repository.Save(server);
|
|
|
|
var serverUpdated = repository.Get(2);
|
|
|
|
// Assert
|
|
Assert.That(serverUpdated, Is.Not.Null);
|
|
Assert.That(serverUpdated.ServerAddress, Is.EqualTo("https://umbraco.com"));
|
|
Assert.That(serverUpdated.IsActive, Is.EqualTo(true));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Delete_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var server = repository.Get(3);
|
|
Assert.IsNotNull(server);
|
|
repository.Delete(server);
|
|
|
|
var exists = repository.Exists(3);
|
|
|
|
// Assert
|
|
Assert.That(exists, Is.False);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Exists_On_Repository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var exists = repository.Exists(3);
|
|
var doesntExist = repository.Exists(10);
|
|
|
|
// Assert
|
|
Assert.That(exists, Is.True);
|
|
Assert.That(doesntExist, Is.False);
|
|
}
|
|
}
|
|
|
|
public void CreateTestData()
|
|
{
|
|
var provider = ScopeProvider;
|
|
using (var scope = provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
repository.Save(new ServerRegistration("http://localhost", "COMPUTER1", DateTime.UtcNow) { IsActive = true });
|
|
repository.Save(new ServerRegistration("http://www.mydomain.com", "COMPUTER2", DateTime.UtcNow));
|
|
repository.Save(new ServerRegistration("https://www.another.domain.com", "Computer3", DateTime.UtcNow));
|
|
scope.Complete();
|
|
}
|
|
}
|
|
}
|