* Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
213 lines
7.2 KiB
C#
213 lines
7.2 KiB
C#
using NUnit.Framework;
|
|
using Umbraco.Cms.Core.Events;
|
|
using Umbraco.Cms.Core.Notifications;
|
|
using Umbraco.Cms.Persistence.EFCore.Scoping;
|
|
using Umbraco.Cms.Tests.Common.Testing;
|
|
using Umbraco.Cms.Tests.Integration.Testing;
|
|
using Umbraco.Cms.Tests.Integration.Umbraco.Persistence.EFCore.DbContext;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Persistence.EFCore.Scoping;
|
|
|
|
[TestFixture]
|
|
[UmbracoTest(Database = UmbracoTestOptions.Database.NewEmptyPerTest)]
|
|
internal sealed class EFCoreScopeNotificationsTest : UmbracoIntegrationTest
|
|
{
|
|
protected override void CustomTestSetup(IUmbracoBuilder builder)
|
|
{
|
|
base.CustomTestSetup(builder);
|
|
|
|
builder.AddNotificationHandler<TestSendNotification, TestSendNotificationHandler>();
|
|
builder.AddNotificationHandler<TestDoNotSendNotification, TestDoNotSendNotificationHandler>();
|
|
}
|
|
|
|
private IEFCoreScopeProvider<TestUmbracoDbContext> EfCoreScopeProvider => GetRequiredService<IEFCoreScopeProvider<TestUmbracoDbContext>>();
|
|
|
|
[Test]
|
|
public void Scope_Can_Send_Notification()
|
|
{
|
|
// We do asserts in the setup of Umbraco, therefore get the
|
|
// current number of asserts right how, and assert later that this
|
|
// has only gone up by 1
|
|
var initialAssertCount = TestContext.CurrentContext.AssertCount;
|
|
|
|
using (var scope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
var savingNotification = new TestSendNotification();
|
|
scope.Notifications.Publish(savingNotification);
|
|
scope.Complete();
|
|
}
|
|
|
|
Assert.AreEqual(initialAssertCount + 1, TestContext.CurrentContext.AssertCount);
|
|
}
|
|
|
|
[Test]
|
|
public void Child_Scope_Can_Send_Notification()
|
|
{
|
|
var initialAssertCount = TestContext.CurrentContext.AssertCount;
|
|
using (var scope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
using (var childScope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
var savingNotification = new TestSendNotification();
|
|
childScope.Notifications.Publish(savingNotification);
|
|
childScope.Complete();
|
|
}
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
Assert.AreEqual(initialAssertCount + 1, TestContext.CurrentContext.AssertCount);
|
|
}
|
|
|
|
[Test]
|
|
public void Scope_Does_Not_Send_Notification_When_Not_Completed()
|
|
{
|
|
using var scope = EfCoreScopeProvider.CreateScope();
|
|
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
scope.Notifications.Publish(savingNotification);
|
|
}
|
|
|
|
[Test]
|
|
public void Scope_Does_Not_Send_Notification_When_Suppressing()
|
|
{
|
|
using var scope = EfCoreScopeProvider.CreateScope();
|
|
scope.Notifications.Suppress();
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
scope.Notifications.Publish(savingNotification);
|
|
scope.Complete();
|
|
}
|
|
|
|
[Test]
|
|
public void Child_Scope_Cannot_Send_Suppressed_Notification()
|
|
{
|
|
using var scope = EfCoreScopeProvider.CreateScope();
|
|
|
|
using (var childScope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
childScope.Notifications.Suppress();
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
childScope.Notifications.Publish(savingNotification);
|
|
}
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
[Test]
|
|
public void Parent_Scope_Can_Send_Notification_Before_Child_Suppressing()
|
|
{
|
|
var initialAssertCount = TestContext.CurrentContext.AssertCount;
|
|
|
|
using (var scope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
var savingParentNotification = new TestSendNotification();
|
|
scope.Notifications.Publish(savingParentNotification);
|
|
using (var childScope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
childScope.Notifications.Suppress();
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
childScope.Notifications.Publish(savingNotification);
|
|
childScope.Complete();
|
|
}
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
Assert.AreEqual(initialAssertCount + 1, TestContext.CurrentContext.AssertCount);
|
|
}
|
|
|
|
[Test]
|
|
public void Parent_Scope_Can_Send_Notification_After_Child_Suppressing()
|
|
{
|
|
var initialAssertCount = TestContext.CurrentContext.AssertCount;
|
|
|
|
|
|
using (var scope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
using (var childScope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
using (childScope.Notifications.Suppress())
|
|
{
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
childScope.Notifications.Publish(savingNotification);
|
|
childScope.Complete();
|
|
}
|
|
}
|
|
|
|
var savingParentNotificationTwo = new TestSendNotification();
|
|
scope.Notifications.Publish(savingParentNotificationTwo);
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
Assert.AreEqual(initialAssertCount + 1, TestContext.CurrentContext.AssertCount);
|
|
}
|
|
|
|
[Test]
|
|
public void Scope_Can_Send_Notification_After_Suppression_Disposed()
|
|
{
|
|
var initialAssertCount = TestContext.CurrentContext.AssertCount;
|
|
|
|
using (var scope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
using (scope.Notifications.Suppress())
|
|
{
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
scope.Notifications.Publish(savingNotification);
|
|
}
|
|
|
|
var savingParentNotificationTwo = new TestSendNotification();
|
|
scope.Notifications.Publish(savingParentNotificationTwo);
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
Assert.AreEqual(initialAssertCount + 1, TestContext.CurrentContext.AssertCount);
|
|
}
|
|
|
|
[Test]
|
|
public void Child_Scope_Does_Not_Send_Notification_When_Parent_Suppressing()
|
|
{
|
|
using var scope = EfCoreScopeProvider.CreateScope();
|
|
scope.Notifications.Suppress();
|
|
|
|
using (var childScope = EfCoreScopeProvider.CreateScope())
|
|
{
|
|
var savingNotification = new TestDoNotSendNotification();
|
|
childScope.Notifications.Publish(savingNotification);
|
|
childScope.Complete();
|
|
}
|
|
|
|
scope.Complete();
|
|
}
|
|
|
|
[Test]
|
|
public void Cant_Suppress_Notifactions_On_Child_When_Parent_Suppressing()
|
|
{
|
|
using var parentScope = EfCoreScopeProvider.CreateScope();
|
|
using var parentSuppressed = parentScope.Notifications.Suppress();
|
|
using var childScope = EfCoreScopeProvider.CreateScope();
|
|
Assert.Throws<InvalidOperationException>(() => childScope.Notifications.Suppress());
|
|
}
|
|
|
|
private class TestSendNotification : INotification
|
|
{
|
|
}
|
|
|
|
private class TestDoNotSendNotification : INotification
|
|
{
|
|
}
|
|
|
|
private class TestSendNotificationHandler : INotificationHandler<TestSendNotification>
|
|
{
|
|
public void Handle(TestSendNotification notification)
|
|
=> Assert.IsNotNull(notification);
|
|
}
|
|
|
|
private class TestDoNotSendNotificationHandler : INotificationHandler<TestDoNotSendNotification>
|
|
{
|
|
public void Handle(TestDoNotSendNotification notification)
|
|
=> Assert.Fail("Notification was sent");
|
|
}
|
|
}
|