* V16: Cache Version Mechanism (#19747) * Add RepositoryCacheVersion table * Add repository * Add Cache version lock * Add GetAll method to repository * Add RepositoryCacheVersionService * Remember to add lock in data creator * Work my way out of constructor hell This is why we use DI folks. 🤦 * Add checks to specific cache policies * Fix migration * Add to schema creator * Fix database access * Initialize the cache version on in memory miss * Make cache version service internal * Add tests * Apply suggestions from code review Co-authored-by: Andy Butland <abutland73@gmail.com> * Add missing obsoletions * Prefer full name --------- Co-authored-by: Andy Butland <abutland73@gmail.com> * fixed merge * V16/feature/move last synced id to db (#19884) * Foundation work for moving last synced id * register manager and repo in dependency injection * Fixing to make tests work * Replacing the use of the old LastSyncedFileManager.cs with the new LastSyncedManager.cs * Testing to delete out of sync id and old entries * changing some stuff to please the reviewer. * Inverted saving methods id check and fixed documentation mishaps * Loadbalancing: Add Cache Sync service to allow us to roll forward isolated caches when backoffice is load balanced. (#20398) * Split cache refreshers into internal and external caches * Add obsolete constructor for CacheInstructionsPruningJob * Add xml docs * Move lastID management into CacheInstructionService * Cache last synced ids in memory * Lock when processing instructions * Sync caches when out of sync * Fix constructors for ICacheSyncService * Cache version on request * Register caches as synced when instructions are processed * Rename CacheVersionAccessor to IRepositoryCacheVersionAccessor * Set caches as synced before actually syncing the caches * Set caches as synced before syncing, within scope, this should also lock the cache version from being written to whilst updating caches * Only check version for backoffice requests * Clear request cache when caches are syned * Default to using NOOP cache version service * Don't generate local identity in database server messenger anymore * Fix ambiguous constructor * Add helper method to switch to load balanced isolated caches * Fix LastSyncedManagerTests * Fix RepositoryCacheVersionServiceTests * Fix DefaultCachePolicyTests * Use correct constructor in FullDataSetRepositoryCachePolicy * Minor cleanup * Add XML docs * Add more xml docs * Apply suggestions from code review Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> --------- Co-authored-by: Zeegaan <skrivdetud@gmail.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Fix migration plan * fix tests * Fix integration tests * Fix changes from github review * Move premigrations to v17 * Make lock constantws sequential * Fix comment * Make IRepositoryCacheVersionService and ICacheSyncService protected on EntityRepositoryBase --------- Co-authored-by: Andy Butland <abutland73@gmail.com> Co-authored-by: Nicklas Kramer <nik@umbraco.dk> Co-authored-by: NillasKA <kramernicklas@gmail.com> Co-authored-by: Zeegaan <skrivdetud@gmail.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
390 lines
12 KiB
C#
390 lines
12 KiB
C#
// Copyright (c) Umbraco.
|
|
// See LICENSE for more details.
|
|
|
|
using System.Globalization;
|
|
using System.Linq;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Cache;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Infrastructure.Persistence;
|
|
using Umbraco.Cms.Infrastructure.Persistence.Repositories.Implement;
|
|
using Umbraco.Cms.Infrastructure.Scoping;
|
|
using Umbraco.Cms.Tests.Common.Testing;
|
|
using Umbraco.Cms.Tests.Integration.Testing;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories;
|
|
|
|
[TestFixture]
|
|
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest)]
|
|
internal sealed class LanguageRepositoryTest : UmbracoIntegrationTest
|
|
{
|
|
[SetUp]
|
|
public void SetUp() => CreateTestData();
|
|
|
|
[Test]
|
|
public void Can_Perform_Get_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (var scope = provider.CreateScope())
|
|
{
|
|
ScopeAccessor.AmbientScope.Database.AsUmbracoDatabase().EnableSqlTrace = true;
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var language = repository.Get(1);
|
|
|
|
// Assert
|
|
Assert.That(language, Is.Not.Null);
|
|
Assert.That(language.HasIdentity, Is.True);
|
|
Assert.That(language.CultureName, Is.EqualTo("English (United States)"));
|
|
Assert.That(language.IsoCode, Is.EqualTo("en-US"));
|
|
Assert.That(language.FallbackIsoCode, Is.Null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Get_By_Iso_Code_On_LanguageRepository()
|
|
{
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
var au = CultureInfo.GetCultureInfo("en-AU");
|
|
ILanguage language = new Language(au.Name, au.EnglishName) { FallbackIsoCode = "en-US" };
|
|
repository.Save(language);
|
|
|
|
// re-get
|
|
language = repository.GetByIsoCode(au.Name);
|
|
|
|
// Assert
|
|
Assert.That(language, Is.Not.Null);
|
|
Assert.That(language.HasIdentity, Is.True);
|
|
Assert.That(language.CultureName, Is.EqualTo(au.EnglishName));
|
|
Assert.That(language.IsoCode, Is.EqualTo(au.Name));
|
|
Assert.That(language.FallbackIsoCode, Is.EqualTo("en-US"));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Get_When_Id_Doesnt_Exist_Returns_Null()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var language = repository.Get(0);
|
|
|
|
// Assert
|
|
Assert.That(language, Is.Null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_GetAll_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var languages = repository.GetMany().ToArray();
|
|
|
|
// Assert
|
|
Assert.That(languages, Is.Not.Null);
|
|
Assert.That(languages.Any(), Is.True);
|
|
Assert.That(languages.Any(x => x == null), Is.False);
|
|
Assert.That(languages.Count(), Is.EqualTo(5));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_GetAll_With_Params_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var languages = repository.GetMany(1, 2).ToArray();
|
|
|
|
// Assert
|
|
Assert.That(languages, Is.Not.Null);
|
|
Assert.That(languages.Any(), Is.True);
|
|
Assert.That(languages.Any(x => x == null), Is.False);
|
|
Assert.That(languages.Count(), Is.EqualTo(2));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_GetByQuery_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (var scope = provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var query = provider.CreateQuery<ILanguage>().Where(x => x.IsoCode == "da-DK");
|
|
var result = repository.Get(query).ToArray();
|
|
|
|
// Assert
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result.Any(), Is.True);
|
|
Assert.That(result.FirstOrDefault().IsoCode, Is.EqualTo("da-DK"));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Count_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (var scope = provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var query = provider.CreateQuery<ILanguage>().Where(x => x.IsoCode.StartsWith("D"));
|
|
var count = repository.Count(query);
|
|
|
|
// Assert
|
|
Assert.That(count, Is.EqualTo(2));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Add_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var languageBR = new Language("pt-BR", "Portuguese (Brazil)");
|
|
repository.Save(languageBR);
|
|
|
|
// Assert
|
|
Assert.That(languageBR.HasIdentity, Is.True);
|
|
Assert.That(languageBR.Id, Is.EqualTo(6)); // With 5 existing entries the Id should be 6
|
|
Assert.IsFalse(languageBR.IsDefault);
|
|
Assert.IsFalse(languageBR.IsMandatory);
|
|
Assert.IsNull(languageBR.FallbackIsoCode);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Add_On_LanguageRepository_With_Boolean_Properties()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var languageBR = new Language("pt-BR", "Portuguese (Brazil)") { IsDefault = true, IsMandatory = true };
|
|
repository.Save(languageBR);
|
|
|
|
// Assert
|
|
Assert.That(languageBR.HasIdentity, Is.True);
|
|
Assert.That(languageBR.Id, Is.EqualTo(6)); // With 5 existing entries the Id should be 6
|
|
Assert.IsTrue(languageBR.IsDefault);
|
|
Assert.IsTrue(languageBR.IsMandatory);
|
|
Assert.IsNull(languageBR.FallbackIsoCode);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Add_On_LanguageRepository_With_Fallback_Language()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var languageBR = new Language("pt-BR", "Portuguese (Brazil)") { FallbackIsoCode = "en-US" };
|
|
repository.Save(languageBR);
|
|
|
|
// Assert
|
|
Assert.That(languageBR.HasIdentity, Is.True);
|
|
Assert.That(languageBR.Id, Is.EqualTo(6)); // With 5 existing entries the Id should be 6
|
|
Assert.That(languageBR.FallbackIsoCode, Is.EqualTo("en-US"));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Add_On_LanguageRepository_With_New_Default()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
ILanguage languageBR = new Language("pt-BR", "Portuguese (Brazil)") { IsDefault = true, IsMandatory = true };
|
|
repository.Save(languageBR);
|
|
var languageEN = new Language("en-AU", "English (Australia)");
|
|
repository.Save(languageEN);
|
|
|
|
Assert.IsTrue(languageBR.IsDefault);
|
|
Assert.IsTrue(languageBR.IsMandatory);
|
|
|
|
// Act
|
|
var languageNZ = new Language("en-NZ", "English (New Zealand)") { IsDefault = true, IsMandatory = true };
|
|
repository.Save(languageNZ);
|
|
languageBR = repository.Get(languageBR.Id);
|
|
|
|
// Assert
|
|
Assert.IsFalse(languageBR.IsDefault);
|
|
Assert.IsTrue(languageNZ.IsDefault);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Update_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var language = repository.Get(5);
|
|
language.IsoCode = "pt-BR";
|
|
language.CultureName = "Portuguese (Brazil)";
|
|
language.FallbackIsoCode = "en-US";
|
|
|
|
repository.Save(language);
|
|
|
|
var languageUpdated = repository.Get(5);
|
|
|
|
// Assert
|
|
Assert.That(languageUpdated, Is.Not.Null);
|
|
Assert.That(languageUpdated.IsoCode, Is.EqualTo("pt-BR"));
|
|
Assert.That(languageUpdated.CultureName, Is.EqualTo("Portuguese (Brazil)"));
|
|
Assert.That(languageUpdated.FallbackIsoCode, Is.EqualTo("en-US"));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Perform_Update_With_Existing_Culture()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var language = repository.Get(5);
|
|
language.IsoCode = "da-DK";
|
|
language.CultureName = "Danish (Denmark)";
|
|
|
|
Assert.Throws<InvalidOperationException>(() => repository.Save(language));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Delete_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var language = repository.Get(3);
|
|
repository.Delete(language);
|
|
|
|
var exists = repository.Exists(3);
|
|
|
|
// Assert
|
|
Assert.That(exists, Is.False);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Delete_On_LanguageRepository_With_Language_Used_As_Fallback()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
// Add language to delete as a fall-back language to another one
|
|
var repository = CreateRepository(provider);
|
|
var languageToFallbackFrom = repository.Get(5);
|
|
languageToFallbackFrom.FallbackIsoCode = "da-DK"; // fall back to "da-DK" (something we can delete)
|
|
repository.Save(languageToFallbackFrom);
|
|
|
|
// delete #2
|
|
var languageToDelete = repository.Get(2);
|
|
repository.Delete(languageToDelete);
|
|
|
|
var exists = repository.Exists(2);
|
|
|
|
// has been deleted
|
|
Assert.That(exists, Is.False);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Perform_Exists_On_LanguageRepository()
|
|
{
|
|
// Arrange
|
|
var provider = ScopeProvider;
|
|
using (provider.CreateScope())
|
|
{
|
|
var repository = CreateRepository(provider);
|
|
|
|
// Act
|
|
var exists = repository.Exists(3);
|
|
var doesntExist = repository.Exists(10);
|
|
|
|
// Assert
|
|
Assert.That(exists, Is.True);
|
|
Assert.That(doesntExist, Is.False);
|
|
}
|
|
}
|
|
|
|
private LanguageRepository CreateRepository(IScopeProvider provider) => new((IScopeAccessor)provider, AppCaches.Disabled, LoggerFactory.CreateLogger<LanguageRepository>(), Mock.Of<IRepositoryCacheVersionService>(), Mock.Of<ICacheSyncService>());
|
|
|
|
private async Task CreateTestData()
|
|
{
|
|
var languageService = GetRequiredService<ILanguageService>();
|
|
|
|
//Id 1 is en-US - when Umbraco is installed
|
|
|
|
var languageDK = new Language("da-DK", "Danish (Denmark)");
|
|
await languageService.CreateAsync(languageDK, Constants.Security.SuperUserKey); //Id 2
|
|
|
|
var languageSE = new Language("sv-SE", "Swedish (Sweden)");
|
|
await languageService.CreateAsync(languageSE, Constants.Security.SuperUserKey); //Id 3
|
|
|
|
var languageDE = new Language("de-DE", "German (Germany)");
|
|
await languageService.CreateAsync(languageDE, Constants.Security.SuperUserKey); //Id 4
|
|
|
|
var languagePT = new Language("pt-PT", "Portuguese (Portugal)");
|
|
await languageService.CreateAsync(languagePT, Constants.Security.SuperUserKey); //Id 5
|
|
}
|
|
}
|