yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes some code duplication by using parameterized test

Browse Source 
Add some debugging to unit test to figure out what's wrong with it
This commit is contained in:
Sebastiaan Janssen
2017-05-21 11:34:21 +02:00
parent d0f69907db
commit 07d91ce9ac
1 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/Umbraco.Tests/Configurations/UmbracoSettings/ContentElementTests.cs
View File

@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using NUnit.Framework;
using Umbraco.Core;
@@ -183,15 +184,28 @@ namespace Umbraco.Tests.Configurations.UmbracoSettings
public void AllowedUploadFiles()
{
Assert.IsTrue(SettingsSection.Content.AllowedUploadFiles.All(x => "jpg,gif,png".Split(',').Contains(x)));
}
}
[Test]
public void IsFileAllowedForUpload_WithWhitelist()
[TestCase("png", true)]
[TestCase("jpg", true)]
[TestCase("gif", true)]
[TestCase("bmp", false)]
[TestCase("php", false)]
[TestCase("ashx", false)]
[TestCase("config", false)]
public void IsFileAllowedForUpload_WithWhitelist(string extension, bool expected)
{
Assert.IsTrue(SettingsSection.Content.IsFileAllowedForUpload("png"));
// TODO: why does this fail on the build server but not locally?
//Assert.IsFalse(SettingsSection.Content.IsFileAllowedForUpload("bmp"));
Assert.IsFalse(SettingsSection.Content.IsFileAllowedForUpload("php"));
Debug.WriteLine("AllowedUploadFiles: {0}", SettingsSection.Content.AllowedUploadFiles);
Debug.WriteLine("DisallowedUploadFiles: {0}", SettingsSection.Content.DisallowedUploadFiles);
var allowedContainsExtension = SettingsSection.Content.AllowedUploadFiles.Any(x => x.InvariantEquals(extension));
var disallowedContainsExtension = SettingsSection.Content.DisallowedUploadFiles.Any(x => x.InvariantEquals(extension));
Debug.WriteLine("AllowedContainsBmp: {0}", allowedContainsExtension);
Debug.WriteLine("DisallowedContainsBmp: {0}", disallowedContainsExtension);
Assert.AreEqual(SettingsSection.Content.IsFileAllowedForUpload(extension), expected);
}
}
}