Missing methods from IMemberService (#13022)

* Add back methods to interface

* Add default implementations to avoid breaking changes

Co-authored-by: Zeegaan <nge@umbraco.dk>

src/Umbraco.Core/Services/IMemberService.cs

@@ -90,6 +90,39 @@ public interface IMemberService : IMembershipMemberService
     /// </returns>
     IMember CreateMember(string username, string email, string name, IMemberType memberType);
 
+    /// <summary>
+    ///     Creates and persists a Member
+    /// </summary>
+    /// <remarks>
+    ///     Using this method will persist the Member object before its returned
+    ///     meaning that it will have an Id available (unlike the CreateMember method)
+    /// </remarks>
+    /// <param name="username">Username of the Member to create</param>
+    /// <param name="email">Email of the Member to create</param>
+    /// <param name="memberTypeAlias">Alias of the MemberType the Member should be based on</param>
+    /// <returns>
+    ///     <see cref="IMember" />
+    /// </returns>
+    IMember CreateMemberWithIdentity(string username, string email, string memberTypeAlias) =>
+        throw new NotImplementedException();
+
+    /// <summary>
+    ///     Creates and persists a Member
+    /// </summary>
+    /// <remarks>
+    ///     Using this method will persist the Member object before its returned
+    ///     meaning that it will have an Id available (unlike the CreateMember method)
+    /// </remarks>
+    /// <param name="username">Username of the Member to create</param>
+    /// <param name="email">Email of the Member to create</param>
+    /// <param name="memberTypeAlias">Alias of the MemberType the Member should be based on</param>
+    /// <param name="isApproved">Whether the member is approved or not</param>
+    /// <returns>
+    ///     <see cref="IMember" />
+    /// </returns>
+    IMember CreateMemberWithIdentity(string username, string email, string memberTypeAlias, bool isApproved) =>
+        throw new NotImplementedException();
+
     /// <summary>
     ///     Creates and persists a Member
     /// </summary>
@@ -106,6 +139,24 @@ public interface IMemberService : IMembershipMemberService
     /// </returns>
     IMember CreateMemberWithIdentity(string username, string email, string name, string memberTypeAlias);
 
+    /// <summary>
+    ///     Creates and persists a Member
+    /// </summary>
+    /// <remarks>
+    ///     Using this method will persist the Member object before its returned
+    ///     meaning that it will have an Id available (unlike the CreateMember method)
+    /// </remarks>
+    /// <param name="username">Username of the Member to create</param>
+    /// <param name="email">Email of the Member to create</param>
+    /// <param name="name">Name of the Member to create</param>
+    /// <param name="memberTypeAlias">Alias of the MemberType the Member should be based on</param>
+    /// <param name="isApproved">Whether the member is approved or not</param>
+    /// <returns>
+    ///     <see cref="IMember" />
+    /// </returns>
+    IMember CreateMemberWithIdentity(string username, string email, string name, string memberTypeAlias, bool isApproved)
+        => throw new NotImplementedException();
+
     /// <summary>
     ///     Creates and persists a Member
     /// </summary>

src/Umbraco.Core/Services/MemberService.cs

@@ -177,7 +177,7 @@ namespace Umbraco.Cms.Core.Services
             => CreateMemberWithIdentity(username, email, username, string.Empty, memberTypeAlias);
 
         public IMember CreateMemberWithIdentity(string username, string email, string memberTypeAlias, bool isApproved)
-            => CreateMemberWithIdentity(username, email, string.Empty, string.Empty, memberTypeAlias, isApproved);
+            => CreateMemberWithIdentity(username, email, username, string.Empty, memberTypeAlias, isApproved);
 
         public IMember CreateMemberWithIdentity(string username, string email, string name, string memberTypeAlias)
             => CreateMemberWithIdentity(username, email, name, string.Empty, memberTypeAlias);