yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed issue with max validation using default 0 value. (#18616)

Browse Source
This commit is contained in:
Andy Butland
2025-03-10 10:57:23 +01:00
committed by GitHub
parent cb78e524d8
commit 0d79a1f443
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Umbraco.Infrastructure/PropertyEditors/SliderPropertyEditor.cs
View File

@@ -10,7 +10,6 @@ using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Models.Editors;
using Umbraco.Cms.Core.Models.Validation;
using Umbraco.Cms.Core.PropertyEditors.Validation;
using Umbraco.Cms.Core.PropertyEditors.Validators;
using Umbraco.Cms.Core.Serialization;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Strings;
@@ -261,7 +260,7 @@ public class SliderPropertyEditor : DataEditor
["value"]);
}
if (sliderRange.To > sliderConfiguration.MaximumValue)
if (sliderConfiguration.MaximumValue != 0 && sliderRange.To > sliderConfiguration.MaximumValue)
{
yield return new ValidationResult(
LocalizedTextService.Localize("validation", "outOfRangeMaximum", [sliderRange.To.ToString(), sliderConfiguration.MaximumValue.ToString()]),

15
tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/SliderValueEditorTests.cs
View File

@@ -205,6 +205,21 @@ public class SliderValueEditorTests
}
}
[Test]
public void Max_Item_Validation_Respects_0_As_Unlimited()
{
var value = new JsonObject
{
{ "from", 1.0m },
{ "to", 1.0m },
};
var editor = CreateValueEditor();
editor.ConfigurationObject = new SliderConfiguration();
var result = editor.Validate(value, false, null, PropertyValidationContext.Empty());
Assert.IsEmpty(result);
}
[TestCase(0.2, 1.3, 1.7, true)]
[TestCase(0.2, 1.4, 1.7, false)]
[TestCase(0.2, 1.3, 1.6, false)]