yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V8: Health check http header case sensitivity (#6753)

Browse Source
This commit is contained in:
Tom Pipe
2019-10-28 17:04:20 +00:00
committed by Sebastiaan Janssen
parent 0868b2e1b6
commit 1614dc6e34
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Umbraco.Web/HealthCheck/Checks/Security/BaseHttpHeaderCheck.cs
View File

@@ -78,7 +78,7 @@ namespace Umbraco.Web.HealthCheck.Checks.Security
var response = request.GetResponse();
// Check first for header
success = DoHttpHeadersContainHeader(response);
success = HasMatchingHeader(response.Headers.AllKeys);
// If not found, and available, check for meta-tag
if (success == false && _metaTagOptionAvailable)
@@ -113,9 +113,9 @@ namespace Umbraco.Web.HealthCheck.Checks.Security
};
}
private bool DoHttpHeadersContainHeader(WebResponse response)
private bool HasMatchingHeader(IEnumerable<string> headerKeys)
{
return response.Headers.AllKeys.Contains(_header, StringComparer.InvariantCultureIgnoreCase);
return headerKeys.Contains(_header, StringComparer.InvariantCultureIgnoreCase);
}
private bool DoMetaTagsContainKeyForHeader(WebResponse response)
@@ -127,7 +127,7 @@ namespace Umbraco.Web.HealthCheck.Checks.Security
{
var html = reader.ReadToEnd();
var metaTags = ParseMetaTags(html);
return metaTags.ContainsKey(_header);
return HasMatchingHeader(metaTags.Keys);
}
}
}