yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Verify that root node has domains when multilingual content is published

Browse Source
This commit is contained in:
nikolajlauridsen
2021-10-06 11:37:03 +02:00
parent eaa0f4618f
commit 1921fd8a76
1 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
View File

@@ -398,7 +398,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
[HttpPost]
public ActionResult<IDictionary<string, ContentItemDisplay>> GetEmptyByAliases(ContentTypesByAliases contentTypesByAliases)
{
// It's important to do this operation within a scope to reduce the amount of readlock queries.
// It's important to do this operation within a scope to reduce the amount of readlock queries.
using var scope = _scopeProvider.CreateScope(autoComplete: true);
var contentTypes = contentTypesByAliases.ContentTypeAliases.Select(alias => _contentTypeService.Get(alias));
return GetEmpties(contentTypes, contentTypesByAliases.ParentId).ToDictionary(x => x.ContentTypeAlias);
@@ -1412,6 +1412,12 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
var publishStatus = _contentService.SaveAndPublish(contentItem.PersistedContent, culturesToPublish, _backofficeSecurityAccessor.BackOfficeSecurity.CurrentUser.Id);
wasCancelled = publishStatus.Result == PublishResultType.FailedPublishCancelledByEvent;
successfulCultures = culturesToPublish;
// Verify that there's appropriate cultures configured for the root nude
if (publishStatus.Success && contentItem.ParentId == -1)
{
VerifyRootNodeDomainsForCultures(contentItem, publishStatus);
}
return publishStatus;
}
else
@@ -1425,6 +1431,33 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
}
}
private void VerifyRootNodeDomainsForCultures(ContentItemSave contentItemSave, PublishResult publishResult)
{
IContent persistedContent = contentItemSave.PersistedContent;
var publishedCultures = persistedContent.PublishedCultures.ToList();
// If only a single culture is published we shouldn't have any routing issues
if (publishedCultures.Count() < 2)
{
return;
}
// If more than a single culture is published we need to verify that there's a domain registered for each published culture
IEnumerable<IDomain> assignedDomains = _domainService.GetAssignedDomains(persistedContent.Id, true);
// No domains at all, add a warning, and making it scary, to add domains.
if (assignedDomains.Any() is false)
{
publishResult.EventMessages.Add(new EventMessage(
"Multilingual site",
"Domains are not configured for multilingual site, please contact an administrator, see log for more information",
EventMessageType.Error));
_logger.LogWarning("The root node {RootNodeName} is published with multiple cultures, but no domains are configured, this will cause routing and caching issues, please register domains for: {Cultures}",
persistedContent.Name, string.Join(", ", publishedCultures));
return;
}
}
/// <summary>
/// Validate if publishing is possible based on the mandatory language requirements
/// </summary>