yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1566 from umbraco/bugfix/create-new-extensions-when-constructor-arg-changes

Browse Source 
Bugfix: Reinitialize Extensions when constructor args changes
This commit is contained in:
Lee Kelleher
2024-04-10 14:45:32 +01:00
committed by GitHub
parent 41f726c5c9 86eb21b362
commit 1f8e52d622
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Umbraco.Web.UI.Client/src/packages/core/components/extension-with-api-slot/extension-with-api-slot.element.ts
View File

@@ -46,7 +46,7 @@ export class UmbExtensionWithApiSlotElement extends UmbLitElement {
if (value === this.#type) return;
this.#type = value;
if (this.#attached) {
this._observeExtensions();
this.#observeExtensions();
}
}
#type?: string | string[] | undefined;
@@ -68,7 +68,7 @@ export class UmbExtensionWithApiSlotElement extends UmbLitElement {
if (value === this.#filter) return;
this.#filter = value;
if (this.#attached) {
this._observeExtensions();
this.#observeExtensions();
}
}
#filter: (manifest: any) => boolean = () => true;
@@ -107,8 +107,9 @@ export class UmbExtensionWithApiSlotElement extends UmbLitElement {
return this.#constructorArgs;
}
set apiArgs(newVal: Array<unknown> | UmbApiConstructorArgumentsMethodType<any> | undefined) {
// TODO, compare changes since last time. only reset the ones that changed. This might be better done by the controller is self:
if (newVal === this.#constructorArgs) return;
this.#constructorArgs = newVal;
this.#observeExtensions();
}
#constructorArgs?: Array<unknown> | UmbApiConstructorArgumentsMethodType<any> = [];
@@ -146,11 +147,11 @@ export class UmbExtensionWithApiSlotElement extends UmbLitElement {
connectedCallback(): void {
super.connectedCallback();
this._observeExtensions();
this.#observeExtensions();
this.#attached = true;
}
private _observeExtensions(): void {
#observeExtensions(): void {
this.#extensionsController?.destroy();
if (this.#type) {
this.#extensionsController = new UmbExtensionsElementAndApiInitializer(