corrections
This commit is contained in:
@@ -22,7 +22,7 @@ export class UmbBlockGridManagerContext extends UmbBlockManagerContext<UmbBlockG
|
||||
}
|
||||
|
||||
create(modalData: UmbBlockGridWorkspaceData, layoutEntry: UmbBlockGridLayoutModel, contentElementTypeKey: string) {
|
||||
super.createBlock(modalData, layoutEntry, contentElementTypeKey, this.#createLayoutEntry);
|
||||
return super.createBlock(modalData, layoutEntry, contentElementTypeKey, this.#createLayoutEntry);
|
||||
}
|
||||
|
||||
#createLayoutEntry(
|
||||
|
||||
@@ -19,7 +19,7 @@ export class UmbBlockListManagerContext<
|
||||
}
|
||||
|
||||
create(modalData: UmbBlockListWorkspaceData, layoutEntry: BlockLayoutType, contentElementTypeKey: string) {
|
||||
super.createBlock(modalData, layoutEntry, contentElementTypeKey, this.#createLayoutEntry);
|
||||
return super.createBlock(modalData, layoutEntry, contentElementTypeKey, this.#createLayoutEntry);
|
||||
}
|
||||
|
||||
#createLayoutEntry(
|
||||
|
||||
@@ -161,6 +161,12 @@ export abstract class UmbBlockManagerContext<
|
||||
this.#settings.appendOne(settingsData);
|
||||
}
|
||||
|
||||
abstract create(
|
||||
modalData: UmbBlockWorkspaceData,
|
||||
layoutEntry: BlockLayoutType,
|
||||
contentElementTypeKey: string,
|
||||
): boolean;
|
||||
|
||||
public createBlock<ModalDataType extends UmbBlockWorkspaceData>(
|
||||
modalData: ModalDataType,
|
||||
layoutEntry: Omit<BlockLayoutType, 'contentUdi'>,
|
||||
|
||||
@@ -143,7 +143,7 @@ export class UmbBlockWorkspaceContext<
|
||||
this.#layout.setValue(layoutData as LayoutDataType);
|
||||
|
||||
if (this.#liveEditingMode) {
|
||||
const blockCreated = this.#blockManager.createBlock(
|
||||
const blockCreated = this.#blockManager.create(
|
||||
this.#modalContext.data as UmbBlockWorkspaceData,
|
||||
layoutData,
|
||||
contentElementTypeId,
|
||||
@@ -225,7 +225,7 @@ export class UmbBlockWorkspaceContext<
|
||||
|
||||
if (!this.#liveEditingMode) {
|
||||
if (this.getIsNew() === true) {
|
||||
const blockCreated = this.#blockManager.createBlock(
|
||||
const blockCreated = this.#blockManager.create(
|
||||
this.#modalContext.data as UmbBlockWorkspaceData,
|
||||
layoutData,
|
||||
contentData.contentTypeKey,
|
||||
|
||||
@@ -3,6 +3,7 @@ import type { UmbNotificationDefaultData } from './notification-layout-default.e
|
||||
import { UmbNotificationLayoutDefaultElement } from './notification-layout-default.element.js';
|
||||
import type { UUIToastNotificationLayoutElement } from '@umbraco-cms/backoffice/external/uui';
|
||||
import { UmbNotificationHandler } from '@umbraco-cms/backoffice/notification';
|
||||
import type { UmbTestRunnerWindow } from '@umbraco-cms/internal/test-utils';
|
||||
|
||||
describe('UmbNotificationLayoutDefault', () => {
|
||||
let element: UmbNotificationLayoutDefaultElement;
|
||||
|
||||
@@ -15,10 +15,12 @@ describe('UmbPropertyEditorUIImageCropsConfigurationElement', () => {
|
||||
expect(element).to.be.instanceOf(UmbPropertyEditorUIImageCropsConfigurationElement);
|
||||
});
|
||||
|
||||
/*
|
||||
if ((window as UmbTestRunnerWindow).__UMBRACO_TEST_RUN_A11Y_TEST) {
|
||||
it('passes the a11y audit', async () => {
|
||||
//TODO: This test is broken. It fails at forms because of missing labels even if you have them.
|
||||
// await expect(element).shadowDom.to.be.accessible(defaultA11yConfig);
|
||||
});
|
||||
}
|
||||
*/
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user