U4-8834 Removing code assigning PropertyData IDs for new properties even though it isn't used
This commit is contained in:
@@ -501,17 +501,6 @@ WHERE EXISTS(
|
||||
var propertyFactory = new PropertyFactory(compositionProperties, def.Version, def.Id, def.CreateDate, def.VersionDate);
|
||||
var properties = propertyFactory.BuildEntity(propertyDataDtos.ToArray()).ToArray();
|
||||
|
||||
var newProperties = properties.Where(x => x.HasIdentity == false && x.PropertyType.HasIdentity);
|
||||
|
||||
foreach (var property in newProperties)
|
||||
{
|
||||
var propertyDataDto = new PropertyDataDto { NodeId = def.Id, PropertyTypeId = property.PropertyTypeId, VersionId = def.Version };
|
||||
int primaryKey = Convert.ToInt32(Database.Insert(propertyDataDto));
|
||||
|
||||
property.Version = def.Version;
|
||||
property.Id = primaryKey;
|
||||
}
|
||||
|
||||
foreach (var property in properties)
|
||||
{
|
||||
//NOTE: The benchmarks run with and without the following code show very little change so this is not a perf bottleneck
|
||||
|
||||
@@ -10,6 +10,12 @@ namespace Umbraco.Web.Models.ContentEditing
|
||||
[DataContract(Name = "property", Namespace = "")]
|
||||
public class ContentPropertyBasic
|
||||
{
|
||||
/// <summary>
|
||||
/// This is the cmsPropertyData ID
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// This is not really used for anything
|
||||
/// </remarks>
|
||||
[DataMember(Name = "id", IsRequired = true)]
|
||||
[Required]
|
||||
public int Id { get; set; }
|
||||
|
||||
Reference in New Issue
Block a user