yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Packaging: Fixing bad serialization for data types in packages (#21043)

Browse Source 
* Changing data type serialization to datatype

* Moving and correcting comment
This commit is contained in:
Nicklas Kramer
2025-12-04 10:52:23 +01:00
committed by GitHub
parent d8c03c426e
commit 26efa520bc
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Core/Services/EntityXmlSerializer.cs
View File

@@ -214,7 +214,7 @@ internal sealed class EntityXmlSerializer : IEntityXmlSerializer
xml.Add(new XAttribute("EditorUiAlias", dataType.EditorUiAlias ?? dataType.EditorAlias));
xml.Add(new XAttribute("Definition", dataType.Key));
xml.Add(new XAttribute("DatabaseType", dataType.DatabaseType.ToString()));
xml.Add(new XAttribute("Configuration", _configurationEditorJsonSerializer.Serialize(dataType.ConfigurationObject)));
xml.Add(new XAttribute("Configuration", SerializeDataTypeConfiguration(dataType)));
var folderNames = string.Empty;
var folderKeys = string.Empty;
@@ -708,4 +708,14 @@ internal sealed class EntityXmlSerializer : IEntityXmlSerializer
}
}
}
/// <summary>
/// We have two properties containing configuration data:
/// 1. ConfigurationData - a dictionary that contains all the configuration data stored as key/value pairs.
/// 2. ConfigurationObject - a strongly typed object that represents the configuration data known to the server.
/// To fully be able to restore the package, we need to serialize the full ConfigurationData dictionary, not
/// just the configuration properties known to the server.
/// </summary>
private string SerializeDataTypeConfiguration(IDataType dataType) =>
_configurationEditorJsonSerializer.Serialize(dataType.ConfigurationData);
}