yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Injecting a logger instead of logger factory

Browse Source 
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
This commit is contained in:
Bjarke Berg
2020-09-23 08:40:05 +02:00
parent f413f279eb
commit 28df8d086b
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Core/HealthCheck/Checks/Security/HttpsCheck.cs
View File

@@ -23,18 +23,22 @@ namespace Umbraco.Web.HealthCheck.Checks.Security
private readonly ILocalizedTextService _textService;
private readonly GlobalSettings _globalSettings;
private readonly IIOHelper _ioHelper;
private readonly LoggerFactory _loggerFactory;
private readonly IRequestAccessor _requestAccessor;
private readonly ILogger<ConfigurationService> _logger;
private const string FixHttpsSettingAction = "fixHttpsSetting";
public HttpsCheck(ILocalizedTextService textService, IOptions<GlobalSettings> globalSettings, IIOHelper ioHelper, LoggerFactory loggerFactory, IRequestAccessor requestAccessor)
public HttpsCheck(ILocalizedTextService textService,
IOptions<GlobalSettings> globalSettings,
IIOHelper ioHelper,
IRequestAccessor requestAccessor,
ILogger<ConfigurationService> logger)
{
_textService = textService;
_globalSettings = globalSettings.Value;
_ioHelper = ioHelper;
_loggerFactory = loggerFactory;
_requestAccessor = requestAccessor;
_logger = logger;
}
/// <summary>
@@ -190,7 +194,7 @@ namespace Umbraco.Web.HealthCheck.Checks.Security
{
var configFile = _ioHelper.MapPath("~/Web.config");
const string xPath = "/configuration/appSettings/add[@key='Umbraco.Core.UseHttps']/@value";
var configurationService = new ConfigurationService(configFile, xPath, _textService, _loggerFactory.CreateLogger<ConfigurationService>());
var configurationService = new ConfigurationService(configFile, xPath, _textService, _logger);
var updateConfigFile = configurationService.UpdateConfigFile("true");
if (updateConfigFile.Success)

2
src/Umbraco.Infrastructure/Examine/IndexRebuilder.cs
View File

@@ -66,7 +66,7 @@ namespace Umbraco.Examine
{
populator.Populate(indexes);
}
catch (Exception e)
catch (Exception)
{
_logger.LogError("Index populating failed for populator {Populator}", populator.GetType());
}