AB#5820 - Review fixes / Clean up

src/Umbraco.Tests.Integration/RuntimeTests.cs

@@ -1,10 +1,7 @@
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.AspNetCore.Http;
-using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
 using Moq;
 using NUnit.Framework;
-using System.IO;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Builder;
 using Umbraco.Core;
@@ -16,7 +13,7 @@ using Umbraco.Tests.Integration.Extensions;
 using Umbraco.Tests.Integration.Implementations;
 using Umbraco.Tests.Integration.Testing;
 using Umbraco.Web.BackOffice.AspNetCore;
-using Umbraco.Web.Common.AspNetCore;
+using Umbraco.Web.Common.Extensions;
 
 namespace Umbraco.Tests.Integration
 {

src/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Data.Common;
 using System.IO;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Builder;
@@ -20,8 +19,8 @@ using Umbraco.Core.Strings;
 using Umbraco.Tests.Common.Builders;
 using Umbraco.Tests.Integration.Extensions;
 using Umbraco.Tests.Integration.Implementations;
-using Umbraco.Tests.Testing;
 using Umbraco.Web.BackOffice.AspNetCore;
+using Umbraco.Web.Common.Extensions;
 
 namespace Umbraco.Tests.Integration.Testing
 {

src/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj

@@ -4,6 +4,7 @@
         <OutputType>Exe</OutputType>
         <TargetFramework>netcoreapp3.1</TargetFramework>
         <IsPackable>false</IsPackable>
+        <LangVersion>8</LangVersion>
     </PropertyGroup>
 
     <ItemGroup>

src/Umbraco.Web.Common/AspNetCore/AspNetCoreUmbracoApplicationLifetime.cs

@@ -6,7 +6,7 @@ using Umbraco.Net;
 
 namespace Umbraco.Web.Common.AspNetCore
 {
-    public class AspNetCoreUmbracoApplicationLifetime : IUmbracoApplicationLifetime, IUmbracoApplicationLifetimeManager
+    public class AspNetCoreUmbracoApplicationLifetime :  IUmbracoApplicationLifetimeManager
     {
         private readonly IHttpContextAccessor _httpContextAccessor;
         private readonly IHostApplicationLifetime _hostApplicationLifetime;

src/Umbraco.Web.Common/Extensions/UmbracoCoreServiceCollectionExtensions.cs

@@ -17,9 +17,10 @@ using Umbraco.Core.Logging;
 using Umbraco.Core.Logging.Serilog;
 using Umbraco.Core.Persistence;
 using Umbraco.Core.Runtime;
+using Umbraco.Web.Common.AspNetCore;
 using Umbraco.Web.Common.Runtime.Profiler;
 
-namespace Umbraco.Web.Common.AspNetCore
+namespace Umbraco.Web.Common.Extensions
 {
     public static class UmbracoCoreServiceCollectionExtensions
     {

src/Umbraco.Web.Common/Lifetime/UmbracoRequestLifetime.cs

@@ -3,7 +3,7 @@ using Microsoft.AspNetCore.Http;
 
 namespace Umbraco.Web.Common.Lifetime
 {
-    public class UmbracoRequestLifetime : IUmbracoRequestLifetime, IUmbracoRequestLifetimeManager
+    public class UmbracoRequestLifetime : IUmbracoRequestLifetimeManager
     {
         public event EventHandler<HttpContext> RequestStart;
         public event EventHandler<HttpContext> RequestEnd;

src/Umbraco.Web.Common/Runtime/Profiler/WebProfiler.cs

@@ -119,15 +119,5 @@ namespace Umbraco.Web.Common.Runtime.Profiler
             if (bool.TryParse(request.Cookies["UMB-DEBUG"], out var cUmbDebug)) return cUmbDebug;
             return false;
         }
-
-        /// <summary>
-        ///     Indicates the boot phase.
-        /// </summary>
-        private enum BootPhase
-        {
-            Boot = 0, // boot phase (before the 1st request even begins)
-            BootRequest = 1, // request boot phase (during the 1st request)
-            Booted = 2 // done booting
-        }
     }
 }

src/Umbraco.Web/AspNet/AspNetUmbracoApplicationLifetime.cs

@@ -5,7 +5,7 @@ using Umbraco.Net;
 
 namespace Umbraco.Web.AspNet
 {
-    public class AspNetUmbracoApplicationLifetime : IUmbracoApplicationLifetime, IUmbracoApplicationLifetimeManager
+    public class AspNetUmbracoApplicationLifetime : IUmbracoApplicationLifetimeManager
     {
         private readonly IHttpContextAccessor _httpContextAccessor;