yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fallback to detailed if not telemetry level not set (#14134)

Browse Source 
Co-authored-by: Zeegaan <nge@umbraco.dk>
This commit is contained in:
Nikolaj Geisle
2023-05-11 13:50:47 +02:00
committed by GitHub
parent b0b591821b
commit 36d72ac85c
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Cms.ManagementApi/ViewModels/Installer/InstallViewModel.cs
View File

@@ -13,5 +13,5 @@ public class InstallViewModel
public DatabaseInstallViewModel Database { get; set; } = null!;
[JsonConverter(typeof(JsonStringEnumConverter))]
public TelemetryLevel TelemetryLevel { get; set; } = TelemetryLevel.Basic;
public TelemetryLevel TelemetryLevel { get; set; } = TelemetryLevel.Detailed;
}

2
src/Umbraco.Core/Services/MetricsConsentService.cs
View File

@@ -60,7 +60,7 @@ public class MetricsConsentService : IMetricsConsentService
if (analyticsLevelString is null ||
Enum.TryParse(analyticsLevelString, out TelemetryLevel analyticsLevel) is false)
{
return TelemetryLevel.Basic;
return TelemetryLevel.Detailed;
}
return analyticsLevel;

2
src/Umbraco.New.Cms.Core/Models/Installer/InstallData.cs
View File

@@ -8,5 +8,5 @@ public class InstallData
public DatabaseInstallData Database { get; set; } = null!;
public TelemetryLevel TelemetryLevel { get; set; } = TelemetryLevel.Basic;
public TelemetryLevel TelemetryLevel { get; set; } = TelemetryLevel.Detailed;
}

4
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Telemetry/TelemetryServiceTests.cs
View File

@@ -84,7 +84,7 @@ public class TelemetryServiceTests
};
var manifestParser = CreateManifestParser(manifests);
var metricsConsentService = new Mock<IMetricsConsentService>();
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Basic);
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Detailed);
var sut = new TelemetryService(
manifestParser,
version,
@@ -119,7 +119,7 @@ public class TelemetryServiceTests
};
var manifestParser = CreateManifestParser(manifests);
var metricsConsentService = new Mock<IMetricsConsentService>();
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Basic);
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Detailed);
var sut = new TelemetryService(
manifestParser,
version,