yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove the temp hack - we can now trust the ids

Browse Source
This commit is contained in:
Mads Rasmussen
2023-09-11 14:10:07 +02:00
parent 3e31926dfd
commit 3a1b1185a2
1 changed files with 6 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/repository/document-type.repository.ts
View File

@@ -168,35 +168,15 @@ export class UmbDocumentTypeRepository
// Could potentially be general methods:
async create(documentType: ItemType) {
if (!documentType || !documentType.id) throw new Error('Template is missing');
if (!documentType || !documentType.id) throw new Error('Document Type is missing');
await this.#init;
const { error, data } = await this.#detailDataSource.insert(documentType);
const { error } = await this.#detailDataSource.insert(documentType);
if (!error && data) {
// TODO: The parts here is a hack, when we can trust the IDs we send, then this should be removed/changed:
const splitResultUrl = data.split('/');
const newId = splitResultUrl[splitResultUrl.length - 1];
// Temporary hack while we are not in control of IDs:
const newDocument = { ...(await this.requestById(newId)).data };
if (newDocument) {
const notification = { data: { message: `Document Type created` } };
this.#notificationContext?.peek('positive', notification);
await this.requestRootTreeItems();
// TODO: currently we cannot put this data into our store, cause we don't have the right ID, as the server currently changes it (and other ids of it, container-id and property-id)
//this.#detailStore?.append(newDocument);
//const treeItem = createTreeItem(newDocument);
//this.#treeStore?.appendItems([treeItem]);
return { data: newDocument };
}
if (!error) {
this.#detailStore?.append(documentType);
const treeItem = createTreeItem(documentType);
this.#treeStore?.appendItems([treeItem]);
}
return { error };