yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dont remove items completely

Browse Source
This commit is contained in:
JesmoDev
2024-09-26 02:46:34 +02:00
parent 9886d6a211
commit 3b1526a979
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/Umbraco.Web.UI.Client/src/packages/rte/tiptap/property-editors/tiptap-toolbar-groups-configuration2.element.ts
View File

@@ -201,19 +201,25 @@ export class UmbTiptapToolbarGroupsConfiguration2Element extends UmbLitElement {
});
});
//TODO Should the extensions removed from the toolbar be removed from the original data as well?
// or just put into the hidden extensions list? (just remove the position property)
// add items from this.#originalFormat only if they are not already in the structured data and they have no position
// add items from this.#originalFormat only if they are not already in the structured data. and if they have a position property set, unset it.
this.#originalFormat.forEach((item) => {
if (!item.position) {
const exists = originalData.find((i) => i.alias === item.alias);
if (!exists) {
originalData.push(item);
}
if (!originalData.some((i) => i.alias === item.alias)) {
originalData.push({
alias: item.alias,
});
}
});
// TODO: this code removes the items completely, while the one above just puts them back into the hidden extensions list. Which one do we prefer?
// this.#originalFormat.forEach((item) => {
// if (!item.position) {
// const exists = originalData.find((i) => i.alias === item.alias);
// if (!exists) {
// originalData.push(item);
// }
// }
// });
return originalData;
};