don't request items if the array is empty

This commit is contained in:
Mads Rasmussen
2023-09-27 13:25:32 +02:00
parent 54d81add9f
commit 3cbb69167f

View File

@@ -46,8 +46,9 @@ export class UmbRepositoryItemsManager<ItemType extends ItemResponseModelBaseMod
setUniques(uniques: string[]) {
this.#uniques.next(uniques);
//TODO: Check if it's safe to call requestItems here.
// We don't have to request items if there is no uniques.
if (uniques.length === 0) return;
this.#requestItems();
}
@@ -56,8 +57,8 @@ export class UmbRepositoryItemsManager<ItemType extends ItemResponseModelBaseMod
}
async #requestItems() {
await this.#init;
if (!this.repository) throw new Error('Repository is not initialized');
await this.#init;
if (this.itemsObserver) this.itemsObserver.destroy();
// TODO: Test if its just some items that is gone now, if so then just filter them out. (maybe use code from #removeItem)