yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update the existing date/time property editor to provide a kind of unspecified (#19727)

Browse Source 
* Update the existing date/time property editor to provide a Kind of Unspecified

* Added unit tests
This commit is contained in:
Laura Neto
2025-07-22 11:55:52 +02:00
committed by GitHub
parent 2ce647738f
commit 3fcc09169a
2 changed files with 32 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Core/PropertyEditors/ValueConverters/DatePickerValueConverter.cs
View File

@@ -20,19 +20,16 @@ public class DatePickerValueConverter : PropertyValueConverterBase
internal static DateTime ParseDateTimeValue(object? source)
{
if (source is null)
{
return DateTime.MinValue;
}
if (source is DateTime dateTimeValue)
{
return dateTimeValue;
return DateTime.SpecifyKind(dateTimeValue, DateTimeKind.Unspecified);
}
Attempt<DateTime> attempt = source.TryConvertTo<DateTime>();
return attempt.Success
? attempt.Result
: DateTime.MinValue;
if (source.TryConvertTo<DateTime>() is { Success: true } attempt)
{
return DateTime.SpecifyKind(attempt.Result, DateTimeKind.Unspecified);
}
return DateTime.MinValue;
}
}

25
tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/ValueConverters/DatePickerValueConverterTests.cs Normal file
View File

@@ -0,0 +1,25 @@
using NUnit.Framework;
using Umbraco.Cms.Core.PropertyEditors.ValueConverters;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.PropertyEditors.ValueConverters;
[TestFixture]
public class DatePickerValueConverterTests
{
private static object[] _parseDateTimeValueCases =
[
new object[] { null, DateTime.MinValue },
new object[] { DateTime.MinValue, DateTime.MinValue },
new object[] { new DateTime(2021, 01, 20, 9, 0, 36), new DateTime(2021, 01, 20, 9, 0, 36) },
new object[] { "2021-01-20T09:00:36", new DateTime(2021, 01, 20, 9, 0, 36) },
new object[] { "test", DateTime.MinValue },
];
[TestCaseSource(nameof(_parseDateTimeValueCases))]
public void Can_Parse_DateTime_Value(object? input, DateTime expected)
{
var result = DatePickerValueConverter.ParseDateTimeValue(input);
Assert.AreEqual(expected, result);
Assert.AreEqual(DateTimeKind.Unspecified, result.Kind);
}
}