yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed: an block grid editor accceptance test on the pipeline for v12 (#14240)

Browse Source 
* The attribute we asserted on has been changed which failed our test. The test is updated to match with the correct url

* Updated so we use encodeURI instead of replacing the values in the path
This commit is contained in:
Andreas Zerbst
2023-05-15 08:04:16 +02:00
committed by GitHub
parent 5df655d599
commit 401fa7334b
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/BlockGridEditor/Content/blockGridEditorAdvanced.spec.ts
View File

@@ -44,7 +44,7 @@ test.describe('BlockGridEditorAdvancedContent', () => {
await umbracoApi.media.ensureNameNotExists(customViewItemName);
const imageData = await umbracoApi.media.createImageWithFile(imageName, umbracoFileValue, imageFileName, imagePath, imageMimeType);
const customViewData = await umbracoApi.media.createFileWithFile(customViewItemName, customViewFileName, customViewPath, customViewMimeType);
const customViewMediaPath = customViewData.mediaLink;
@@ -101,7 +101,7 @@ test.describe('BlockGridEditorAdvancedContent', () => {
await umbracoUi.navigateToContent(blockGridName);
// Assert
// Checks if the block has the correct CustomView
// Checks if the block has the correct CustomView
await expect(page.locator('[data-content-element-type-key="' + element['key'] + '"]').locator('[view="' + customViewMediaPath + '"]')).toBeVisible();
// Checks if the custom view updated the block by locating a name in the customView
await expect(page.locator('[data-content-element-type-key="' + element['key'] + '"]').locator('[view="' + customViewMediaPath + '"]').locator('[name="BlockGridCustomView"]')).toBeVisible();
@@ -137,7 +137,7 @@ test.describe('BlockGridEditorAdvancedContent', () => {
await umbracoApi.content.createDefaultContentWithABlockGridEditor(umbracoApi, element, dataType, null);
await umbracoUi.navigateToContent(blockGridName);
// Assert
// Checks if the block has the correct template
await expect(page.locator('umb-block-grid-entry', {hasText: elementName}).locator('umb-block-grid-block')).toHaveAttribute('stylesheet', stylesheetDataPath);
@@ -345,11 +345,12 @@ test.describe('BlockGridEditorAdvancedContent', () => {
// Assert
// Checks if the element has the thumbnail
await expect(page.locator('umb-block-card', {hasText: elementName}).locator('.__showcase')).toHaveAttribute('style', 'background-image: url("' + imageDataPath + '?width=400");');
const updatedImagePath = encodeURIComponent(imageDataPath);
await expect(page.locator('umb-block-card', {hasText: elementName}).locator('.__showcase')).toHaveAttribute('style', 'background-image: url("/umbraco/backoffice/umbracoapi/images/GetBigThumbnail?originalImagePath=' + updatedImagePath + '\");');
// Clean
await umbracoApi.documentTypes.ensureNameNotExists(elementTwoName);
await umbracoApi.media.ensureNameNotExists(imageName);
});
});
});
});