yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2001 from umbraco/chore/remove-extra-arg

Browse Source 
Chore: Remove arg passed to oneEvent method
This commit is contained in:
Lee Kelleher
2024-06-17 12:13:25 +01:00
committed by GitHub
parent 7bf24591de 5e8b9a934e
commit 431d9493a7
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Umbraco.Web.UI.Client/src/libs/context-api/consume/context-consumer.test.ts
View File

@@ -2,7 +2,7 @@ import { expect, oneEvent } from '@open-wc/testing';
import { UmbContextProvider } from '../provide/context-provider.js';
import { UmbContextToken } from '../token/context-token.js';
import { UmbContextConsumer } from './context-consumer.js';
import type { UmbContextRequestEventImplementation} from './context-request.event.js';
import type { UmbContextRequestEventImplementation } from './context-request.event.js';
import { UMB_CONTENT_REQUEST_EVENT_TYPE } from './context-request.event.js';
const testContextAlias = 'my-test-context';
@@ -39,7 +39,7 @@ describe('UmbContextConsumer', () => {
describe('events', () => {
it('dispatches context request event when constructed', async () => {
const listener = oneEvent(window, UMB_CONTENT_REQUEST_EVENT_TYPE, false);
const listener = oneEvent(window, UMB_CONTENT_REQUEST_EVENT_TYPE);
consumer.hostConnected();

4
src/Umbraco.Web.UI.Client/src/packages/core/property/property-dataset/property-dataset.element.test.ts
View File

@@ -133,7 +133,7 @@ describe('UmbBasicVariantElement', () => {
});
it('fires change event', async () => {
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE, false);
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE);
expect(propertyEditor.alias).to.eq('testAlias');
propertyEditor.setValue('testValue3');
@@ -153,7 +153,7 @@ describe('UmbBasicVariantElement', () => {
adapterPropertyEditor.alias = 'testAdapterAlias';
datasetElement.appendChild(adapterPropertyEditor);
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE, false);
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE);
// The alias of the original property editor must be 'testAlias' for the adapter to set the value of it.
expect(propertyEditor.alias).to.eq('testAlias');

2
src/Umbraco.Web.UI.Client/src/packages/core/utils/pagination-manager/pagination.manager.test.ts
View File

@@ -141,7 +141,7 @@ describe('UmbPaginationManager', () => {
});
it('dispatches a change event', async () => {
const listener = oneEvent(manager, UmbChangeEvent.TYPE, false);
const listener = oneEvent(manager, UmbChangeEvent.TYPE);
manager.setCurrentPageNumber(2);
const event = (await listener) as unknown as UmbChangeEvent;
const target = event.target as UmbPaginationManager;