yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

more clean up

Browse Source
This commit is contained in:
Niels Lyngsø
2024-01-26 13:21:42 +01:00
parent cd2b75038a
commit 442446ff23
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Umbraco.Web.UI.Client/src/libs/extension-api/registry/extension.registry.ts
View File

@@ -106,7 +106,7 @@ export class UmbExtensionRegistry<
}
register(manifest: ManifestTypes | ManifestKind<ManifestTypes>): void {
const isValid = this.checkExtension(manifest);
const isValid = this.#checkExtension(manifest);
if (!isValid) {
return;
}
@@ -143,14 +143,7 @@ export class UmbExtensionRegistry<
return false;
}
/*
getByAlias(alias: string) {
// TODO: make pipes prettier/simpler/reuseable
return this.extensions.pipe(map((extensions) => extensions.find((extension) => extension.alias === alias) || null));
}
*/
private checkExtension(manifest: ManifestTypes | ManifestKind<ManifestTypes>): boolean {
#checkExtension(manifest: ManifestTypes | ManifestKind<ManifestTypes>): boolean {
if (!manifest.type) {
console.error(`Extension is missing type`, manifest);
return false;
@@ -345,6 +338,7 @@ export class UmbExtensionRegistry<
* @param type {string} - The type of the extensions to get.
* @returns {Observable<T | undefined>} - An observable of the extensions that matches the type.
*/
// TODO: get rid of the extensions name.
extensionsOfType<
Key extends keyof ManifestTypeMap<ManifestTypes> | string,
T extends ManifestBase = SpecificManifestTypeOrManifestBase<ManifestTypes, Key>,
@@ -375,6 +369,7 @@ export class UmbExtensionRegistry<
* @param type {Array<string>} - The types of the extensions to get.
* @returns {Observable<T | undefined>} - An observable of the extensions that matches the types.
*/
// TODO: get rid of the extensions name.
extensionsOfTypes<ExtensionTypes extends ManifestBase = ManifestBase>(
types: string[],
): Observable<Array<ExtensionTypes>> {