yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rule to accept element base for abstract element class names (#17969)

Browse Source
This commit is contained in:
Niels Lyngsø
2025-01-14 08:59:41 +01:00
committed by GitHub
parent 42f49eb564
commit 45603e2689
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-element-suffix-on-element-class-name.cjs
View File

@@ -12,11 +12,16 @@ module.exports = {
create: function (context) {
return {
ClassDeclaration(node) {
// check if class is abstract
const isAbstract = node.abstract;
// check if the class extends HTMLElement, LitElement, or UmbLitElement
const isExtendingElement =
node.superClass && ['HTMLElement', 'LitElement', 'UmbLitElement'].includes(node.superClass.name);
// check if the class name ends with 'Element'
const isClassNameValid = node.id.name.endsWith('Element');
// check if the class name ends with 'Element' or 'ElementBase'
const isClassNameValid = node.id.name.endsWith('Element') || isAbstract && node.id.name.endsWith('ElementBase');
if (isExtendingElement && !isClassNameValid) {
context.report({