yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed setting the Is404 flag

Browse Source
This commit is contained in:
Shannon Deminick
2012-09-13 12:23:58 +07:00
parent 9e5f2f3c9a
commit 458f1d3b8f
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Web/Routing/DefaultLastChanceLookup.cs
View File

@@ -48,12 +48,6 @@ namespace Umbraco.Web.Routing
docRequest.RoutingContext.UmbracoContext,
handler.redirectID);
//SD: We are setting the Is404 to true here because these are 404 handlers.
// if people in the future add their own last chance lookup resolver, they might not want things to be 404s
// and instead do their own thing so we should leave it up to the last chance resolver to set the 404, not the
// module.
docRequest.Is404 = true;
// FIXME - could it be null?
LogHelper.Debug<DefaultLastChanceLookup>("Handler '{0}' found node with id={1}.", () => handler.GetType().FullName, () => handler.redirectID);
@@ -76,6 +70,12 @@ namespace Umbraco.Web.Routing
}
}
//SD: We are setting the Is404 to true here because these are 404 handlers.
// if people in the future add their own last chance lookup resolver, they might not want things to be 404s
// and instead do their own thing so we should leave it up to the last chance resolver to set the 404, not the
// module.
docRequest.Is404 = true;
return currentPage;
}