Apply suggestions from code review

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
This commit is contained in:
Nikolaj Geisle
2021-10-04 11:31:38 +02:00
committed by GitHub
parent 17e53e497c
commit 45badbd36b
4 changed files with 4 additions and 8 deletions

View File

@@ -26,8 +26,6 @@ using Umbraco.Cms.Core.IO;
using Umbraco.Cms.Core.Logging;
using Umbraco.Cms.Core.Mail;
using Umbraco.Cms.Core.Manifest;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Models.Membership;
using Umbraco.Cms.Core.Models.PublishedContent;
using Umbraco.Cms.Core.Notifications;
using Umbraco.Cms.Core.PropertyEditors;

View File

@@ -11,7 +11,7 @@ namespace Umbraco.Cms.Core.Services
{
public class UserDataService : IUserDataService
{
private IUmbracoVersion _version;
private readonly IUmbracoVersion _version;
private readonly ILocalizationService _localizationService;
public UserDataService(IUmbracoVersion version, ILocalizationService localizationService)
{

View File

@@ -17,11 +17,8 @@ namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Services
private IUmbracoVersion _umbracoVersion;
private ILocalizationService _localizationService;
[SetUp]
public void CreateMocks()
{
CreateUmbracoVersion(9, 0, 0);
}
[OneTimeSetUp]
public void CreateMocks() => CreateUmbracoVersion(9, 0, 0);
[Test]
[TestCase("en-US")]

View File

@@ -163,6 +163,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
var userTours = JsonConvert.DeserializeObject<IEnumerable<UserTourStatus>>(_backofficeSecurityAccessor.BackOfficeSecurity.CurrentUser.TourData);
return userTours;
}
public IEnumerable<UserData> GetUserData()
{
return _userDataService.GetUserData();