yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return PackageInstance as opposed to CreatedPackage in API responses

Browse Source
This commit is contained in:
Warren Buckley
2018-12-06 11:21:28 +00:00
parent c7e6cf44ed
commit 465229fb39
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Web/Editors/PackageController.cs
View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Web.Http;
@@ -18,20 +19,21 @@ namespace Umbraco.Web.Editors
public class PackageController : UmbracoAuthorizedJsonController
{
[HttpGet]
public List<CreatedPackage> GetCreatedPackages()
public List<PackageInstance> GetCreatedPackages()
{
//TODO: Could be too much data down the wire
return CreatedPackage.GetAllCreatedPackages();
return CreatedPackage.GetAllCreatedPackages().Select(x => x.Data).ToList();
}
[HttpGet]
public CreatedPackage GetCreatedPackageById(int id)
public PackageInstance GetCreatedPackageById(int id)
{
return CreatedPackage.GetById(id);
//TODO throw an error if cant find by ID
return CreatedPackage.GetById(id).Data;
}
[HttpPost]
public CreatedPackage PostCreatePackage(PackageInstance model)
public PackageInstance PostCreatePackage(PackageInstance model)
{
//TODO Validation on the model?!
var newPackage = new CreatedPackage
@@ -42,14 +44,15 @@ namespace Umbraco.Web.Editors
//Save then publish
newPackage.Save();
newPackage.Publish();
//We should have packagepath populated now
return newPackage;
return newPackage.Data;
}
[HttpDelete]
public HttpResponseMessage DeleteCreatedPackageById(int id)
{
//TODO: Validation ensure can find it by ID
var package = CreatedPackage.GetById(id);
package.Delete();