yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make system media types clonable (#17641)

Browse Source
This commit is contained in:
Nikolaj Geisle
2024-11-27 07:33:13 +01:00
committed by GitHub
parent 475faba5fd
commit 5200181ea2
2 changed files with 26 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Core/Models/MediaType.cs
View File

@@ -12,6 +12,7 @@ namespace Umbraco.Cms.Core.Models;
public class MediaType : ContentTypeCompositionBase, IMediaType
{
public const bool SupportsPublishingConst = false;
private bool _isCloning;
/// <summary>
/// Constuctor for creating a MediaType with the parent's id.
@@ -52,7 +53,7 @@ public class MediaType : ContentTypeCompositionBase, IMediaType
get => base.Alias;
set
{
if (this.IsSystemMediaType() && value != Alias)
if (this.IsSystemMediaType() && value != Alias && _isCloning is false)
{
throw new InvalidOperationException("Cannot change the alias of a system media type");
}
@@ -62,6 +63,16 @@ public class MediaType : ContentTypeCompositionBase, IMediaType
}
/// <inheritdoc />
IMediaType IMediaType.DeepCloneWithResetIdentities(string newAlias) =>
(IMediaType)DeepCloneWithResetIdentities(newAlias);
// This is very hacky, but we cannot override the base DeepCloneWithResetIdentities as it would be breaking.
// We have to be able to set a new alias when cloning system types.
// TODO: Make ContentTypeBase.DeepCloneWithResetIdentities overrideable.
IMediaType IMediaType.DeepCloneWithResetIdentities(string newAlias)
{
_isCloning = true;
var clone = (IMediaType)DeepCloneWithResetIdentities(newAlias);
_isCloning = false;
return clone;
}
}

14
src/Umbraco.Core/Services/ContentTypeServiceBaseOfTRepositoryTItemTService.cs
View File

@@ -947,8 +947,18 @@ public abstract class ContentTypeServiceBase<TRepository, TItem> : ContentTypeSe
// this is illegal
//var copyingb = (ContentTypeCompositionBase) copying;
// but we *know* it has to be a ContentTypeCompositionBase anyways
var copyingb = (ContentTypeCompositionBase) (object)copying;
copy = (TItem) (object) copyingb.DeepCloneWithResetIdentities(alias);
// TODO: Fix back to only calling the copyingb.DeepCloneWithResetIdentities when
// when ContentTypeBase.DeepCloneWithResetIdentities is overrideable.
if (copying is IMediaType mediaTypeToCope)
{
copy = (TItem)mediaTypeToCope.DeepCloneWithResetIdentities(alias);
}
else
{
var copyingb = (ContentTypeCompositionBase) (object)copying;
copy = (TItem) (object) copyingb.DeepCloneWithResetIdentities(alias);
}
copy.Name = copy.Name + " (copy)"; // might not be unique