V8: Accessibility Changes For umbEditorHeader Directive (settings section) (#6986)

* Improved accessibility of the data type edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Improved accessibility of the macro edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Improved accessibility of the relation type edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Added to do note for log viewer

src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js

@@ -224,7 +224,8 @@ Use this directive to construct a header inside the main editor window.
             if (editorState.current) {
                 //to do make work for user create/edit
                 // to do make it work for user group create/ edit
-                // to make it work for language edit/create
+                // to do make it work for language edit/create
+                // to do make it work for log viewer
                 scope.isNew = editorState.current.id === 0 ||
                     editorState.current.id === "0" ||
                     editorState.current.id === -1 ||

src/Umbraco.Web.UI.Client/src/views/datatypes/datatype.edit.controller.js

@@ -10,7 +10,11 @@ function DataTypeEditController($scope, $routeParams, appState, navigationServic
     
     var evts = [];
     var vm = this;
-    
+
+    vm.header = {};
+    vm.header.editorfor = "visuallyHiddenTexts_newDataType";
+    vm.header.setPageTitle = true;
+
     //setup scope vars
     vm.page = {};
     vm.page.loading = false;

src/Umbraco.Web.UI.Client/src/views/datatypes/edit.html

@@ -8,7 +8,9 @@
                             hide-icon="true"
                             hide-description="true"
                             hide-alias="true"
-                            navigation="vm.page.navigation">
+                            navigation="vm.page.navigation"
+                            editorfor="vm.header.editorfor"
+                            setpagetitle="vm.header.setPageTitle">
             </umb-editor-header>
 
             <umb-editor-container class="form-horizontal">

src/Umbraco.Web.UI.Client/src/views/macros/edit.html

@@ -6,7 +6,8 @@
                                alias="vm.macro.alias"
                                hide-description="true"
                                hide-icon="true"
-                               navigation="vm.page.navigation">
+                               navigation="vm.page.navigation"editorfor="vm.header.editorfor"
+                               setpagetitle="vm.header.setPageTitle">
             </umb-editor-header>
 
             <umb-editor-container class="form-horizontal">

src/Umbraco.Web.UI.Client/src/views/macros/macros.edit.controller.js

@@ -11,7 +11,10 @@ function MacrosEditController($scope, $q, $routeParams, macroResource, editorSta
     var vm = this;
 
     vm.promises = {};
-    
+    vm.header = {};
+    vm.header.editorfor = "general_macro";
+    vm.header.setPageTitle = true;
+
     vm.page = {};
     vm.page.loading = false;
     vm.page.saveButtonState = "init";

src/Umbraco.Web.UI.Client/src/views/relationtypes/edit.controller.js

@@ -10,6 +10,10 @@ function RelationTypeEditController($scope, $routeParams, relationTypeResource,
 
     var vm = this;
 
+    vm.header = {};
+    vm.header.editorfor = "relationType_tabRelationType";
+    vm.header.setPageTitle = true;
+
     vm.page = {};
     vm.page.loading = false;
     vm.page.saveButtonState = "init";

src/Umbraco.Web.UI.Client/src/views/relationtypes/edit.html

@@ -8,7 +8,9 @@
                 alias="vm.relationType.alias"
                 hide-description="true"
                 hide-icon="true"
-                navigation="vm.page.navigation">
+                navigation="vm.page.navigation"
+                editorfor="vm.header.editorfor"
+                setpagetitle="vm.header.setPageTitle">
             </umb-editor-header>
 
             <umb-editor-container class="form-horizontal">