yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add pipe first() to prevent the loader from running multiple times

Browse Source
This commit is contained in:
Jacob Overgaard
2023-02-23 16:53:03 +01:00
parent b4245cf423
commit 5c95b75b0c
1 changed files with 24 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/Umbraco.Web.UI.Client/src/backoffice/packages/repository/server-package.controller.ts
View File

@@ -1,4 +1,4 @@
import { Subject, takeUntil } from 'rxjs';
import { first, Subject, takeUntil } from 'rxjs';
import { UmbPackageRepository } from './package.repository';
import { UmbController, UmbControllerHostInterface } from '@umbraco-cms/controller';
import { isManifestJSType, UmbExtensionRegistry } from '@umbraco-cms/extensions-api';
@@ -25,22 +25,29 @@ export class UmbServerPackageController extends UmbController {
async #loadPackages() {
const package$ = await this.#repository.rootItems();
package$.pipe(takeUntil(this.#unobserve)).subscribe((packages) => {
// Go through packages and register their extensions
packages.forEach((p) => {
const { extensions } = p;
if (extensions?.length) {
extensions.forEach((extension) => {
/**
* Crude check to see if extension is of type "js" since it is safe to assume we do not
* need to load any other types of extensions in the backoffice (we need a js file to load)
*/
if (isManifestJSType(extension)) {
this.extensionRegistry.register(extension);
}
});
}
package$
.pipe(
// If the app breaks then stop the request
takeUntil(this.#unobserve),
// Stop after the first time, we only need to load the packages once
first()
)
.subscribe((packages) => {
// Go through packages and register their extensions
packages.forEach((p) => {
const { extensions } = p;
if (extensions?.length) {
extensions.forEach((extension) => {
/**
* Crude check to see if extension is of type "js" since it is safe to assume we do not
* need to load any other types of extensions in the backoffice (we need a js file to load)
*/
if (isManifestJSType(extension)) {
this.extensionRegistry.register(extension);
}
});
}
});
});
});
}
}