Fixes: U4-3741 GetMemberFromLoginNameAndPassword Always Return Null

This commit is contained in:
Shannon
2013-12-09 13:08:06 +11:00
parent 6ec297aaaf
commit 69ffecd686
2 changed files with 7 additions and 25 deletions

View File

@@ -359,30 +359,7 @@ namespace Umbraco.Tests
Assert.IsNull(shouldNotFind);
}
/// <summary>
/// This demonstrates this issue: http://issues.umbraco.org/issue/U4-3505 - the TypeList was returning a list of assignable types
/// not explicit types which is sort of ideal but is confusing so we'll do it the less confusing way.
/// </summary>
[Test]
public void TypeList_Resolves_Explicit_Types()
{
var types = new HashSet<PluginManager.TypeList>();
var propEditors = new PluginManager.TypeList<PropertyEditor>(PluginManager.TypeResolutionKind.FindAllTypes);
propEditors.AddType(typeof (LabelPropertyEditor));
types.Add(propEditors);
var found = types.SingleOrDefault(x => x.IsTypeList<PropertyEditor>(PluginManager.TypeResolutionKind.FindAllTypes));
Assert.IsNotNull(found);
//This should not find a type list of this type
var shouldNotFind = types.SingleOrDefault(x => x.IsTypeList<IParameterEditor>(PluginManager.TypeResolutionKind.FindAllTypes));
Assert.IsNull(shouldNotFind);
}
[XsltExtension("Blah.Blah")]
public class MyXsltExtension
{

View File

@@ -793,7 +793,7 @@ namespace umbraco.providers.members
}
//check for approve status. If not approved, then set the member property to null
if (!CheckApproveStatus(m)) {
if (m != null && !CheckApproveStatus(m)) {
m = null;
}
@@ -859,6 +859,11 @@ namespace umbraco.providers.members
}
}
}
else
{
//There is no property so we shouldn't use the approve status
isApproved = true;
}
}
}
else {