yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

minus n

Browse Source
This commit is contained in:
Niels Lyngsø
2023-03-10 14:38:03 +01:00
parent fab5e776b4
commit 7140c483fb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Web.UI.Client/libs/modal/modal-handler.ts
View File

@@ -107,7 +107,7 @@ export class UmbModalHandler {
return this._closePromise;
}
/* TODO: modals being part of the extension registry know means that a modal element can change over time.
/* TODO: modals being part of the extension registry now means that a modal element can change over time.
It makes this code a bit more complex. The main idea is to have the element as part of the modalHandler so it is possible to dispatch events from within the modal element to the one that opened it.
Now when the element is an observable it makes it more complex because this host needs to subscribe to updates to the element, instead of just having a reference to it.
If we find a better generic solution to communicate between the modal and the implementor, then we can remove the element as part of the modalHandler. */