yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensures that we log exceptions instead of completely ignoring them

Browse Source
This commit is contained in:
Shannon
2014-03-20 14:17:00 +11:00
parent a721ed5e0f
commit 7475851bb5
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Umbraco.Web/ImageCropperBaseExtensions.cs
View File

@@ -15,7 +15,7 @@ namespace Umbraco.Web
{
internal static class ImageCropperBaseExtensions
{
internal static ImageCropData GetImageCrop(this string json, string id)
{
var ic = new ImageCropData();
@@ -26,7 +26,10 @@ namespace Umbraco.Web
var imageCropperSettings = JsonConvert.DeserializeObject<List<ImageCropData>>(json);
ic = imageCropperSettings.GetCrop(id);
}
catch { }
catch (Exception ex)
{
LogHelper.Error(typeof(ImageCropperBaseExtensions), "Could not parse the json string: " + json, ex);
}
}
return ic;
}
@@ -40,9 +43,9 @@ namespace Umbraco.Web
{
imageCrops = JsonConvert.DeserializeObject<ImageCropDataSet>(json);
}
catch(Exception ex)
catch (Exception ex)
{
var e = ex;
LogHelper.Error(typeof(ImageCropperBaseExtensions), "Could not parse the json string: " + json, ex);
}
}
@@ -57,7 +60,8 @@ namespace Umbraco.Web
return dataset.Crops.GetCrop(cropAlias);
}
internal static ImageCropData GetCrop(this IEnumerable<ImageCropData> dataset, string cropAlias){
internal static ImageCropData GetCrop(this IEnumerable<ImageCropData> dataset, string cropAlias)
{
if (dataset == null || !dataset.Any())
return null;
@@ -92,7 +96,7 @@ namespace Umbraco.Web
}
}
return false;
}
}
return false;
}