Apply suggestions from code review

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
This commit is contained in:
Shannon Deminick
2021-02-05 12:32:09 +11:00
committed by GitHub
parent eed8e4dca8
commit 7aff288ff1
3 changed files with 3 additions and 3 deletions

View File

@@ -37,7 +37,7 @@ namespace Umbraco.Web.Common.Extensions
pattern.Append('/').Append(controllerName);
}
pattern.Append('/').Append("{action}/{id?}");
pattern.Append("/{action}/{id?}");
var defaults = defaultAction.IsNullOrWhiteSpace()
? (object)new { controller = controllerName }

View File

@@ -31,7 +31,7 @@ namespace Umbraco.Web.Common.ModelBinders
// in the aspnet pipeline it will really only support converting from IPublishedContent which is contained
// in the UmbracoRouteValues --> IContentModel
UmbracoRouteValues umbracoRouteValues = bindingContext.HttpContext.Features.Get<UmbracoRouteValues>();
if (umbracoRouteValues == null)
if (umbracoRouteValues is null)
{
return Task.CompletedTask;
}

View File

@@ -41,7 +41,7 @@ namespace Umbraco.Web.Website.Controllers
get
{
UmbracoRouteValues umbracoRouteValues = HttpContext.Features.Get<UmbracoRouteValues>();
if (umbracoRouteValues == null)
if (umbracoRouteValues is null)
{
throw new InvalidOperationException($"No {nameof(UmbracoRouteValues)} feature was found in the HttpContext");
}