Apply suggestions from code review
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
This commit is contained in:
@@ -37,7 +37,7 @@ namespace Umbraco.Web.Common.Extensions
|
||||
pattern.Append('/').Append(controllerName);
|
||||
}
|
||||
|
||||
pattern.Append('/').Append("{action}/{id?}");
|
||||
pattern.Append("/{action}/{id?}");
|
||||
|
||||
var defaults = defaultAction.IsNullOrWhiteSpace()
|
||||
? (object)new { controller = controllerName }
|
||||
|
||||
@@ -31,7 +31,7 @@ namespace Umbraco.Web.Common.ModelBinders
|
||||
// in the aspnet pipeline it will really only support converting from IPublishedContent which is contained
|
||||
// in the UmbracoRouteValues --> IContentModel
|
||||
UmbracoRouteValues umbracoRouteValues = bindingContext.HttpContext.Features.Get<UmbracoRouteValues>();
|
||||
if (umbracoRouteValues == null)
|
||||
if (umbracoRouteValues is null)
|
||||
{
|
||||
return Task.CompletedTask;
|
||||
}
|
||||
|
||||
@@ -41,7 +41,7 @@ namespace Umbraco.Web.Website.Controllers
|
||||
get
|
||||
{
|
||||
UmbracoRouteValues umbracoRouteValues = HttpContext.Features.Get<UmbracoRouteValues>();
|
||||
if (umbracoRouteValues == null)
|
||||
if (umbracoRouteValues is null)
|
||||
{
|
||||
throw new InvalidOperationException($"No {nameof(UmbracoRouteValues)} feature was found in the HttpContext");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user