minor changes

This commit is contained in:
Niels Lyngsø
2023-11-14 15:18:46 +01:00
parent 918d6b32ca
commit 85e6ebee45
2 changed files with 6 additions and 4 deletions

View File

@@ -48,7 +48,7 @@ class UmbTestExtensionsController<
UmbTestExtensionController,
MyPermittedControllerType
> {
#host: UmbControllerHost;
#extensionRegistry: UmbExtensionRegistry<ManifestWithDynamicConditions>;
constructor(
host: UmbControllerHost,
extensionRegistry: UmbExtensionRegistry<ManifestWithDynamicConditions>,
@@ -57,12 +57,13 @@ class UmbTestExtensionsController<
onChange: (permittedManifests: Array<MyPermittedControllerType>) => void
) {
super(host, extensionRegistry, type, filter, onChange);
this.#host = host;
this.#extensionRegistry = extensionRegistry;
this._init();
}
protected _createController(manifest: ManifestWithDynamicConditions) {
return new UmbTestExtensionController(this.#host, testExtensionRegistry, manifest.alias, this._extensionChanged);
return new UmbTestExtensionController(this, this.#extensionRegistry, manifest.alias, this._extensionChanged);
}
}
@@ -109,6 +110,7 @@ describe('UmbBaseExtensionsController', () => {
it('exposes both manifests', (done) => {
let count = 0;
const extensionController = new UmbTestExtensionsController(
hostElement,
testExtensionRegistry,

View File

@@ -2,7 +2,7 @@ import { UmbApi } from "../models/api.interface.js";
import { ManifestApi, ManifestElementAndApi } from "../types/base.types.js";
import { loadManifestApi } from "./load-manifest-api.function.js";
export async function createExtensionApi<ApiType extends UmbApi = UmbApi>(manifest: ManifestApi<ApiType> | ManifestElementAndApi<any, ApiType>, constructorArguments: unknown[] = []): Promise<ApiType | undefined> {
export async function createExtensionApi<ApiType extends UmbApi = UmbApi>(manifest: ManifestApi<ApiType> | ManifestElementAndApi<any, ApiType>, constructorArguments: Array<unknown> = []): Promise<ApiType | undefined> {
if(manifest.api) {
const apiConstructor = await loadManifestApi<ApiType>(manifest.api);