yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Nested content optimizations (#10236)

Browse Source 
* Reducing the large amount of objects allocated and make use of the attemped dictionary cache

* Reverting optimization by passing data from a higher level - not really possible to achieve what we wanted and adding faster way to lookup value editors
This commit is contained in:
Elitsa Marinovska
2021-06-29 09:55:02 +02:00
committed by GitHub
parent c6832491b6
commit 897cb11f00
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Web/PropertyEditors/NestedContentPropertyEditor.cs
View File

@@ -156,6 +156,7 @@ namespace Umbraco.Web.PropertyEditors
public override object ToEditor(Property property, IDataTypeService dataTypeService, string culture = null, string segment = null)
{
var val = property.GetValue(culture, segment);
var valEditors = new Dictionary<int, IDataValueEditor>();
var rows = _nestedContentValues.GetPropertyValues(val);
@@ -184,8 +185,15 @@ namespace Umbraco.Web.PropertyEditors
continue;
}
var tempConfig = dataTypeService.GetDataType(prop.Value.PropertyType.DataTypeId).Configuration;
var valEditor = propEditor.GetValueEditor(tempConfig);
var dataTypeId = prop.Value.PropertyType.DataTypeId;
if (!valEditors.TryGetValue(dataTypeId, out var valEditor))
{
var tempConfig = dataTypeService.GetDataType(dataTypeId).Configuration;
valEditor = propEditor.GetValueEditor(tempConfig);
valEditors.Add(dataTypeId, valEditor);
}
var convValue = valEditor.ToEditor(tempProp, dataTypeService);
// update the raw value since this is what will get serialized out