Clean up - Removed duplicate ctor in UmbracoVersion

src/Umbraco.Core/Configuration/UmbracoVersion.cs

@@ -10,14 +10,6 @@ namespace Umbraco.Core.Configuration
     /// </summary>
     public class UmbracoVersion : IUmbracoVersion
     {
-        private readonly GlobalSettings _globalSettings;
-
-        public UmbracoVersion(GlobalSettings globalSettings)
-            : this()
-        {
-            _globalSettings = globalSettings;
-        }
-
         public UmbracoVersion()
         {
             var umbracoCoreAssembly = typeof(SemVersion).Assembly;

src/Umbraco.Tests.Common/TestHelperBase.cs

@@ -128,7 +128,7 @@ namespace Umbraco.Tests.Common
             return relativePath.Replace("~/", bin + "/");
         }
 
-        public IUmbracoVersion GetUmbracoVersion() => new UmbracoVersion(new GlobalSettingsBuilder().Build());
+        public IUmbracoVersion GetUmbracoVersion() => new UmbracoVersion();
 
         public IRegister GetRegister()
         {

src/Umbraco.Tests/Testing/UmbracoTestBase.cs

@@ -178,7 +178,7 @@ namespace Umbraco.Tests.Testing
 
             IBackOfficeInfo backOfficeInfo = new AspNetBackOfficeInfo(ConfigModelConversionsToLegacy.ConvertGlobalSettings(globalSettings), IOHelper, logger, settings);
             IIpResolver ipResolver = new AspNetIpResolver();
-            UmbracoVersion = new UmbracoVersion(globalSettings);
+            UmbracoVersion = new UmbracoVersion();
 
 
             LocalizedTextService = new LocalizedTextService(new Dictionary<CultureInfo, Lazy<XDocument>>(), logger);

src/Umbraco.Web.Common/Extensions/UmbracoCoreServiceCollectionExtensions.cs

@@ -126,7 +126,7 @@ namespace Umbraco.Extensions
             services.Configure<UserPasswordConfigurationSettings>(configuration.GetSection(Constants.Configuration.ConfigSecurityPrefix + "UserPassword"));
             services.Configure<WebRoutingSettings>(configuration.GetSection(Constants.Configuration.ConfigPrefix + "WebRouting"));
 
-            // TODO: remove this once no longer requred in Umbraco.Web.	
+            // TODO: remove this once no longer requred in Umbraco.Web.
             var configsFactory = new AspNetCoreConfigsFactory(configuration);
             var configs = configsFactory.Create();
             services.AddSingleton(configs);
@@ -238,7 +238,7 @@ namespace Umbraco.Extensions
                 loggingConfiguration,
                 out var logger, out var ioHelper, out var hostingEnvironment, out var backOfficeInfo, out var profiler);
 
-            var umbracoVersion = new UmbracoVersion(globalSettings);
+            var umbracoVersion = new UmbracoVersion();
             var typeFinder = CreateTypeFinder(logger, profiler, webHostEnvironment, entryAssembly, typeFinderSettings);
 
             var configs = serviceProvider.GetService<Configs>();

src/Umbraco.Web/UmbracoApplicationBase.cs

@@ -160,7 +160,7 @@ namespace Umbraco.Web
 
 
             var globalSettings =  Umbraco.Composing.Current.Configs.Global();
-            var umbracoVersion = new UmbracoVersion(ConfigModelConversionsFromLegacy.ConvertGlobalSettings(globalSettings));
+            var umbracoVersion = new UmbracoVersion();
 
             // create the register for the application, and boot
             // the boot manager is responsible for registrations