yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up subscriptions

Browse Source
This commit is contained in:
Mads Rasmussen
2022-07-04 12:07:02 +02:00
parent bc69709d6d
commit 99069d3e3c
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Umbraco.Web.UI.Client/src/backoffice/property-actions/property-action-menu/property-action-menu.element.ts
View File

@@ -54,13 +54,14 @@ export class UmbPropertyActionMenuElement extends UmbContextProviderMixin(UmbCon
private _open = false;
private _extensionRegistry?: UmbExtensionRegistry;
private _subscription?: Subscription;
private _propertyActionsSubscription?: Subscription;
private _propertyActionMenuContext = new UmbPropertyActionMenuContext();
private _propertyActionMenuOpenSubscription?: Subscription;
constructor () {
super();
this._propertyActionMenuContext.isOpen.subscribe((value: boolean) => {
this._propertyActionMenuOpenSubscription = this._propertyActionMenuContext.isOpen.subscribe((value: boolean) => {
this._open = value;
});
@@ -73,7 +74,7 @@ export class UmbPropertyActionMenuElement extends UmbContextProviderMixin(UmbCon
}
private _usePropertyActions () {
this._subscription?.unsubscribe();
this._propertyActionsSubscription?.unsubscribe();
this._extensionRegistry?.extensionsOfType('propertyAction')
.pipe(
@@ -95,7 +96,8 @@ export class UmbPropertyActionMenuElement extends UmbContextProviderMixin(UmbCon
disconnectedCallback () {
super.disconnectedCallback();
this._subscription?.unsubscribe();
this._propertyActionMenuOpenSubscription?.unsubscribe();
this._propertyActionsSubscription?.unsubscribe();
}
render () {