chore(sonarcloud): fix issues

src/Umbraco.Web.UI.Client/src/packages/rte/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts

@@ -18,6 +18,7 @@ import {
 	renderEditor,
 } from '@umbraco-cms/backoffice/external/tinymce';
 import type { UmbPropertyEditorConfigCollection } from '@umbraco-cms/backoffice/property-editor';
+import { ImageCropModeModel } from '@umbraco-cms/backoffice/external/backend-api';
 
 /**
  * Handles the resize event
@@ -41,7 +42,7 @@ async function onResize(
 	const resizedPath = await getProcessedImageUrl(path, {
 		width: e.width,
 		height: e.height,
-		mode: 'max',
+		mode: ImageCropModeModel.MAX,
 	});
 
 	e.target.setAttribute('data-mce-src', resizedPath);
@@ -54,8 +55,8 @@ export class UmbInputTinyMceElement extends UUIFormControlMixin(UmbLitElement, '
 
 	#plugins: Array<ClassConstructor<UmbTinyMcePluginBase> | undefined> = [];
 	#editorRef?: Editor | null = null;
-	#stylesheetRepository = new UmbStylesheetDetailRepository(this);
-	#umbStylesheetRuleManager = new UmbStylesheetRuleManager();
+	readonly #stylesheetRepository = new UmbStylesheetDetailRepository(this);
+	readonly #umbStylesheetRuleManager = new UmbStylesheetRuleManager();
 
 	protected override getFormElement() {
 		return this._editorElement?.querySelector('iframe') ?? undefined;
@@ -93,14 +94,13 @@ export class UmbInputTinyMceElement extends UUIFormControlMixin(UmbLitElement, '
 	#readonly = false;
 
 	@query('.editor', true)
-	private _editorElement?: HTMLElement;
+	private readonly _editorElement?: HTMLElement;
 
 	getEditor() {
 		return this.#editorRef;
 	}
 
-	constructor() {
-		super();
+	override firstUpdated() {
 		this.#loadEditor();
 	}
 
@@ -226,8 +226,8 @@ export class UmbInputTinyMceElement extends UUIFormControlMixin(UmbLitElement, '
 
 		// set the configured toolbar if any, otherwise false
 		const toolbar = this.configuration?.getValueByAlias<string[]>('toolbar');
-		if (toolbar && toolbar.length) {
-			configurationOptions.toolbar = toolbar?.join(' ');
+		if (toolbar?.length) {
+			configurationOptions.toolbar = toolbar.join(' ');
 		} else {
 			configurationOptions.toolbar = false;
 		}
@@ -338,9 +338,9 @@ export class UmbInputTinyMceElement extends UUIFormControlMixin(UmbLitElement, '
 			 */
 			const allNodes = Array.from(editor.dom.doc.getElementsByTagName('*'));
 			allNodes.forEach((node) => {
-				for (let i = 0; i < node.attributes.length; i++) {
-					if (node.attributes[i].name.startsWith('on')) {
-						node.removeAttribute(node.attributes[i].name);
+				for (const attr of node.attributes) {
+					if (attr.name.startsWith('on')) {
+						node.removeAttribute(attr.name);
 					}
 				}
 			});

src/Umbraco.Web.UI.Client/src/packages/rte/tiny-mce/components/input-tiny-mce/input-tiny-mce.sanitizer.ts

@@ -46,4 +46,16 @@ export const uriAttributeSanitizer = (editor: Editor) => {
 			return uri;
 		};
 	})();
+
+	editor.serializer.addAttributeFilter('uriAttributesToSanitize', function (nodes) {
+		nodes.forEach(function (node) {
+			if (!node.attributes) return;
+			for (const attr of node.attributes) {
+				const attrName = attr.name.toLowerCase();
+				if (uriAttributesToSanitize.indexOf(attrName) !== -1) {
+					attr.value = parseUri(attr.value, node.name) ?? '';
+				}
+			}
+		});
+	});
 };

src/Umbraco.Web.UI.Client/src/packages/rte/tiny-mce/plugins/tiny-mce-mediapicker.plugin.ts

@@ -31,7 +31,7 @@ interface MediaPickerResultData {
 
 export default class UmbTinyMceMediaPickerPlugin extends UmbTinyMcePluginBase {
 	#modalManager?: typeof UMB_MODAL_MANAGER_CONTEXT.TYPE;
-	#temporaryFileRepository;
+	readonly #temporaryFileRepository;
 
 	constructor(args: TinyMcePluginArguments) {
 		super(args);
@@ -144,7 +144,7 @@ export default class UmbTinyMceMediaPickerPlugin extends UmbTinyMcePluginBase {
 		if (!modalHandler) return;
 
 		const { selection } = await modalHandler.onSubmit().catch(() => ({ selection: undefined }));
-		if (!selection || !selection.length) return;
+		if (!selection?.length) return;
 
 		this.#showMediaCaptionAltText(selection[0], currentTarget);
 		this.editor.dispatch('Change');
@@ -200,13 +200,11 @@ export default class UmbTinyMceMediaPickerPlugin extends UmbTinyMcePluginBase {
 			} else {
 				parentElement.innerHTML = combined;
 			}
-		} else {
+		} else if (parentElement?.nodeName === 'FIGURE' && parentElement.parentElement) {
 			//if caption is removed, remove the figure element
-			if (parentElement?.nodeName === 'FIGURE' && parentElement.parentElement) {
-				parentElement.parentElement.innerHTML = newImage;
-			} else {
-				this.editor.selection.setContent(newImage);
-			}
+			parentElement.parentElement.innerHTML = newImage;
+		} else {
+			this.editor.selection.setContent(newImage);
 		}
 
 		// Using settimeout to wait for a DoM-render, so we can find the new element by ID.

src/Umbraco.Web.UI.Client/src/packages/rte/tiny-mce/property-editors/toolbar/property-editor-ui-tiny-mce-toolbar-configuration.element.ts

@@ -128,7 +128,7 @@ export class UmbPropertyEditorUITinyMceToolbarConfigurationElement
 		</ul>`;
 	}
 
-	static override styles = [
+	static override readonly styles = [
 		UmbTextStyles,
 		css`
 			ul {