yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove usages of angular.forEach in property editors

Browse Source
This commit is contained in:
Kenn Jacobsen
2020-07-31 14:08:20 +02:00
committed by Sebastiaan Janssen
parent e69f19381f
commit a737b0eacf
4 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Web.UI.Client/src/views/propertyeditors/contentpicker/contentpicker.controller.js
View File

@@ -446,7 +446,7 @@ function contentPickerController($scope, $q, $routeParams, $location, entityReso
if (entityType !== "Member") {
entityResource.getUrl(entity.id, entityType).then(function (data) {
// update url
angular.forEach($scope.renderModel, function (item) {
$scope.renderModel.forEach(function (item) {
if (item.id === entity.id) {
if (entity.trashed) {
item.url = vm.labels.general_recycleBin;

2
src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js
View File

@@ -955,7 +955,7 @@ angular.module("umbraco")
$scope.availableEditors = response.data;
//Localize the grid editor names
angular.forEach($scope.availableEditors, function (value, key) {
$scope.availableEditors.forEach(function (value) {
//If no translation is provided, keep using the editor name from the manifest
localizationService.localize("grid_" + value.alias, undefined, value.name).then(function (v) {
value.name = v;

18
src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts/list/list.listviewlayout.controller.js
View File

@@ -86,22 +86,20 @@
}
function markAsSensitive() {
angular.forEach($scope.options.includeProperties, function (option) {
$scope.options.includeProperties.forEach(function (option) {
option.isSensitive = false;
angular.forEach($scope.items,
function (item) {
$scope.items.forEach(function (item) {
angular.forEach(item.properties,
function (property) {
item.properties.forEach(function (property) {
if (option.alias === property.alias) {
option.isSensitive = property.isSensitive;
}
if (option.alias === property.alias) {
option.isSensitive = property.isSensitive;
}
});
});
});
});
});
}

3
src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
View File

@@ -498,8 +498,7 @@
if (tab) {
scaffold.variants[0].tabs.push(tab);
angular.forEach(tab.properties,
function (property) {
tab.properties.forEach(function (property) {
if (_.find(notSupported, function (x) { return x === property.editor; })) {
property.notSupported = true;
// TODO: Not supported message to be replaced with 'content_nestedContentEditorNotSupported' dictionary key. Currently not possible due to async/timing quirk.