yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

notes for dirty state

Browse Source
This commit is contained in:
Niels Lyngsø
2024-02-28 07:53:42 +01:00
parent 18df6f43ee
commit b6c2137cbc
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Umbraco.Web.UI.Client/src/packages/core/workspace/workspace-context/editable-workspace-context-base.ts
View File

@@ -1,13 +1,13 @@
import { UMB_WORKSPACE_CONTEXT } from './workspace-context.token.js';
import type { UmbSaveableWorkspaceContextInterface } from './saveable-workspace-context.interface.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { UmbBaseController } from '@umbraco-cms/backoffice/class-api';
import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
import { UmbBooleanState } from '@umbraco-cms/backoffice/observable-api';
import type { UmbModalContext } from '@umbraco-cms/backoffice/modal';
import { UMB_MODAL_CONTEXT } from '@umbraco-cms/backoffice/modal';
export abstract class UmbEditableWorkspaceContextBase<WorkspaceDataModelType>
extends UmbBaseController
extends UmbContextBase<UmbEditableWorkspaceContextBase<WorkspaceDataModelType>>
implements UmbSaveableWorkspaceContextInterface
{
public readonly workspaceAlias: string;
@@ -18,10 +18,17 @@ export abstract class UmbEditableWorkspaceContextBase<WorkspaceDataModelType>
#isNew = new UmbBooleanState(undefined);
isNew = this.#isNew.asObservable();
/*
Concept notes: [NL]
Considerations are, if we bring a dirty state (observable) we need to maintain it all the time.
This might be too heavy process, so we might want to consider just having a get dirty state method.
*/
//#isDirty = new UmbBooleanState(undefined);
//isDirty = this.#isNew.asObservable();
constructor(host: UmbControllerHost, workspaceAlias: string) {
super(host);
super(host, UMB_WORKSPACE_CONTEXT.toString());
this.workspaceAlias = workspaceAlias;
this.provideContext(UMB_WORKSPACE_CONTEXT, this);
this.consumeContext(UMB_MODAL_CONTEXT, (context) => {
(this.modalContext as UmbModalContext) = context;
});
@@ -49,6 +56,7 @@ export abstract class UmbEditableWorkspaceContextBase<WorkspaceDataModelType>
}
}
//abstract getIsDirty(): Promise<boolean>;
abstract getUnique(): string | undefined; // TODO: Consider if this should go away/be renamed? now that we have getUnique()
abstract getEntityType(): string;
abstract getData(): WorkspaceDataModelType | undefined;