yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Modal: Remove unused uui-dialog element in modal component (#21030)

Browse Source 
refactor(backoffice): remove unused uui-dialog element in modal component

Remove dead code that created an unnecessary uui-dialog element inside uui-modal-dialog. The uui-modal-dialog component already manages its own internal dialog element, making the manual creation redundant.

This aligns the dialog implementation with the sidebar implementation pattern, where container elements manage their own internal structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Lee Kelleher
2025-12-02 17:04:19 +00:00
committed by GitHub
parent 5e1f758117
commit bcec927e64
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal.element.ts
View File

@@ -10,7 +10,6 @@ import { UmbBasicState, type UmbObserverController } from '@umbraco-cms/backoffi
import { import {
UUIModalCloseEvent, UUIModalCloseEvent,
type UUIModalElement, type UUIModalElement,
type UUIDialogElement,
type UUIModalDialogElement, type UUIModalDialogElement,
type UUIModalSidebarElement, type UUIModalSidebarElement,
type UUIModalSidebarSize, type UUIModalSidebarSize,
@@ -127,8 +126,6 @@ export class UmbModalElement extends UmbLitElement {
#createDialogElement() { #createDialogElement() {
const modalDialogElement = document.createElement('uui-modal-dialog'); const modalDialogElement = document.createElement('uui-modal-dialog');
const dialogElement: UUIDialogElement = document.createElement('uui-dialog');
modalDialogElement.appendChild(dialogElement);
return modalDialogElement; return modalDialogElement;
} }