yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

child selector directive - unbind watchers on destroy

Browse Source
This commit is contained in:
Mads Rasmussen
2015-08-03 10:08:21 +02:00
parent 8e78e91543
commit c1db51c62e
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Web.UI.Client/src/common/directives/components/umbchildselector.directive.js
View File

@@ -145,7 +145,7 @@
}
scope.$watch('parentName', function(newValue, oldValue){
var unbindParentNameWatch = scope.$watch('parentName', function(newValue, oldValue){
if (newValue === oldValue) { return; }
if ( oldValue === undefined || newValue === undefined) { return; }
@@ -154,7 +154,7 @@
});
scope.$watch('parentIcon', function(newValue, oldValue){
var unbindParentIconWatch = scope.$watch('parentIcon', function(newValue, oldValue){
if (newValue === oldValue) { return; }
if ( oldValue === undefined || newValue === undefined) { return; }
@@ -162,7 +162,7 @@
syncParentIcon();
});
scope.$watch('availableChildren', function(newValue, oldValue){
var unbindAvailableChildrenWatch = scope.$watch('availableChildren', function(newValue, oldValue){
if (newValue === oldValue) { return; }
if ( oldValue === undefined || newValue === undefined) { return; }
@@ -175,7 +175,7 @@
});
scope.$watch('selectedChildren', function(newValue, oldValue){
var unbindSelectedChildrenWatch = scope.$watch('selectedChildren', function(newValue, oldValue){
if (newValue === oldValue) { return; }
if ( oldValue === undefined || newValue === undefined) { return; }
@@ -183,6 +183,15 @@
scope.selectedChildren = createSelectedChildrenObjectArray(scope.selectedChildren, scope.availableChildren);
});
// clean up
scope.$on('$destroy', function(){
// unbind watchers
unbindParentNameWatch();
unbindParentIconWatch();
unbindAvailableChildrenWatch();
unbindSelectedChildrenWatch();
});
}
var directive = {