yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixes n+1 query when assigning user types to users in user repo

Browse Source
This commit is contained in:
Shannon
2014-09-02 12:21:29 +10:00
parent 03f9b89810
commit c76d09c9b0
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/Umbraco.Core/Persistence/Repositories/UserRepository.cs
View File

@@ -370,21 +370,12 @@ namespace Umbraco.Core.Persistence.Repositories
private IEnumerable<IUser> ConvertFromDtos(IEnumerable<UserDto> dtos)
{
var foundUserTypes = new Dictionary<short, IUserType>();
var userTypeIds = dtos.Select(x => Convert.ToInt32(x.Type)).ToArray();
var allUserTypes = _userTypeRepository.GetAll(userTypeIds);
return dtos.Select(dto =>
{
//first we need to get the user type
IUserType userType;
if (foundUserTypes.ContainsKey(dto.Type))
{
userType = foundUserTypes[dto.Type];
}
else
{
userType = _userTypeRepository.Get(dto.Type);
//put it in the local cache
foundUserTypes.Add(dto.Type, userType);
}
{
var userType = allUserTypes.Single(x => x.Id == dto.Type);
var userFactory = new UserFactory(userType);
return userFactory.BuildEntity(dto);