yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update umbBlockGridPropertyEditor.component.js

Browse Source 
currently checks the first group or tab (index 0) that was added to see if there are properties.

This doesn't work well when the tab has a single group, and the group is created after the tab, as the tab will be empty, even though the group has the properties. 

there is also some interactions when composing tabs from other doc types, but I didn't have a good amount of time to test this.
This commit is contained in:
James
2023-08-26 13:20:15 +12:00
committed by Emma L Garland
parent 46b0833d52
commit cd2855634e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbBlockGridPropertyEditor.component.js
View File

@@ -493,7 +493,7 @@
block.showValidation = true;
block.hideContentInOverlay = block.config.forceHideContentEditorInOverlay === true;
block.showContent = !block.hideContentInOverlay && block.content?.variants[0].tabs[0]?.properties.length > 0;
block.showContent = !block.hideContentInOverlay && block.content?.variants[0].tabs?.some(tab=>tab.properties.length) === true;
block.showSettings = block.config.settingsElementTypeKey != null;
// If we have content, otherwise it doesn't make sense to copy.