yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Take care of FIXMEs

Browse Source
This commit is contained in:
Stephan
2013-09-23 16:55:59 +02:00
parent 3de2196e01
commit d925f856ae
9 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Core/CoreBootManager.cs
View File

@@ -258,7 +258,7 @@ namespace Umbraco.Core
MigrationResolver.Current = new MigrationResolver(
() => PluginManager.Current.ResolveMigrationTypes());
// fixme - remove support for obsolete PropertyEditorValueConverter
// todo: remove once we drop IPropertyEditorValueConverter support.
PropertyEditorValueConvertersResolver.Current = new PropertyEditorValueConvertersResolver(
PluginManager.Current.ResolvePropertyEditorValueConverters());

2
src/Umbraco.Core/Models/IPublishedContent.cs
View File

@@ -148,7 +148,7 @@ namespace Umbraco.Core.Models
/// <para>The recursive syntax (eg "_title") is _not_ supported here.</para>
/// <para>The alias is case-insensitive.</para>
/// </remarks>
object this[string alias] { get; } // fixme - should obsolete this[alias]
object this[string alias] { get; } // todo - should obsolete this[alias] (when?)
#endregion
}

5
src/Umbraco.Core/Models/PublishedContent/PublishedPropertyType.cs
View File

@@ -86,7 +86,7 @@ namespace Umbraco.Core.Models.PublishedContent
{
var converters = PropertyValueConvertersResolver.Current.Converters.ToArray();
// fixme - get rid of the IPropertyValueEditorConverter support eventually
// todo: remove Union() once we drop IPropertyEditorValueConverter support.
_converter = null;
foreach (var converter in converters.Union(GetCompatConverters()).Where(x => x.IsConverter(this)))
{
@@ -206,8 +206,9 @@ namespace Umbraco.Core.Models.PublishedContent
#region Compat
// fixme - remove in v7
// backward-compatibility: support IPropertyEditorValueConverter while we have to
// todo: remove once we drop IPropertyEditorValueConverter support.
IEnumerable<IPropertyValueConverter> GetCompatConverters()
{
return PropertyEditorValueConvertersResolver.HasCurrent

4
src/Umbraco.Core/PropertyEditors/IPropertyEditorValueConverter.cs
View File

@@ -5,8 +5,8 @@ namespace Umbraco.Core.PropertyEditors
/// <summary>
/// Maps a property source value to a data object.
/// </summary>
// fixme - should obsolete that class
public interface IPropertyEditorValueConverter
// todo: drop IPropertyEditorValueConverter support (when?).
public interface IPropertyEditorValueConverter
{
/// <summary>
/// Returns a value indicating whether this provider applies to the specified property.

4
src/Umbraco.Tests/CodeFirst/TestModels/Home.cs
View File

@@ -10,9 +10,7 @@ namespace Umbraco.Tests.CodeFirst.TestModels
[PropertyType(typeof(TextFieldDataType))]
public string SiteName { get; set; }
// fixme - yet the property alias is "siteDescription"?
[Alias("umbSiteDescription", Name = "Site Description")]
[Alias("umbSiteDescription", Name = "Site Description")] // ignored by the mapper at the moment
[PropertyType(typeof(textfieldMultipleDataType))]
public string SiteDescription { get; set; }
}

10
src/Umbraco.Tests/DynamicsAndReflection/ExtensionMethodFinderTests.cs
View File

@@ -78,13 +78,13 @@ namespace Umbraco.Tests.DynamicsAndReflection
var m5 = typeof(ExtensionMethodFinderTests).GetMethod("TestMethod5");
// fixme - currently that fails because we can't match List<T> with List<int32>
// note - currently that fails because we can't match List<T> with List<int32>
var a5 = new object[] {new List<int>()};
var m5A = GetMethodForArguments(m5, a5);
Assert.IsNotNull(m5A);
// fixme - should we also handle "ref" and "out" parameters?
// fixme - should we pay attention to array types?
// note - should we also handle "ref" and "out" parameters?
// note - should we pay attention to array types?
}
public void TestMethod1(int value) {}
@@ -122,7 +122,7 @@ namespace Umbraco.Tests.DynamicsAndReflection
var pos = parameterType.GenericParameterPosition;
if (genericArgumentTypes[pos] != null)
{
// fixme - is this OK? what about variance and such?
// note - is this OK? what about variance and such?
// it is NOT ok, if the first pass is SomethingElse then next is Something
// it will fail... the specs prob. indicate how it works, trying to find a common
// type...
@@ -172,7 +172,7 @@ namespace Umbraco.Tests.DynamicsAndReflection
method.Invoke(null, new object[] { class1, 1 });
method = ExtensionMethodFinder.FindExtensionMethod(typeof(Class1), new object[] { "x" }, "TestMethod1", false);
Assert.IsNull(method); // fixme - fails, return TestMethod1!
Assert.IsNull(method); // note - fails, return TestMethod1!
method = ExtensionMethodFinder.FindExtensionMethod(typeof(Class1), new object[] { 1 }, "TestMethod2", false);
Assert.IsNotNull(method);

6
src/Umbraco.Tests/PublishedContent/PublishedContentDataTableTests.cs
View File

@@ -126,6 +126,7 @@ namespace Umbraco.Tests.PublishedContent
private IPublishedContent GetContent(bool createChildren, int indexVals)
{
var contentTypeAlias = createChildren ? "Parent" : "Child";
var z = new SolidPublishedContent(null;)
var d = new TestPublishedContent
{
CreateDate = DateTime.Now,
@@ -174,7 +175,8 @@ namespace Umbraco.Tests.PublishedContent
return d;
}
// fixme - why can't we just use SolidPublishedContent here?
// note - could probably rewrite those tests using SolidPublishedContentCache
// l8tr...
private class TestPublishedContent : IPublishedContent
{
public string Url { get; set; }
@@ -214,7 +216,7 @@ namespace Umbraco.Tests.PublishedContent
public object this[string propertyAlias]
{
get { return GetProperty(propertyAlias).DataValue; } // fixme - why DataValue here?
get { return GetProperty(propertyAlias).ObjectValue; }
}
public IEnumerable<IPublishedContent> Children { get; set; }

2
src/Umbraco.Tests/PublishedContent/PublishedContentTestElements.cs
View File

@@ -149,7 +149,7 @@ namespace Umbraco.Tests.PublishedContent
{
var index = this.Siblings().FindIndex(x => x.Id == Id);
if (index < 0)
throw new IndexOutOfRangeException(""); // fixme
throw new IndexOutOfRangeException("Failed to find content in its siblings collection?!");
return index;
}

4
src/Umbraco.Tests/Routing/ContentFinderByAliasWithDomainsTests.cs
View File

@@ -52,9 +52,9 @@ namespace Umbraco.Tests.Routing
}
[TestCase("http://domain1.com/this/is/my/alias", "de-DE", -1001)] // alias to domain's page fails FIXME wanted?
[TestCase("http://domain1.com/this/is/my/alias", "de-DE", -1001)] // alias to domain's page fails - no alias on domain's home
[TestCase("http://domain1.com/page2/alias", "de-DE", 10011)] // alias to sub-page works
[TestCase("http://domain1.com/en/flux", "en-US", -10011)] // alias to domain's page fails FIXME wanted?
[TestCase("http://domain1.com/en/flux", "en-US", -10011)] // alias to domain's page fails - no alias on domain's home
[TestCase("http://domain1.com/endanger", "de-DE", 10011)] // alias to sub-page works, even with "en..."
[TestCase("http://domain1.com/en/endanger", "en-US", -10011)] // no
[TestCase("http://domain1.com/only/one/alias", "de-DE", 100111)] // ok