yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better exception message when using ALTER TABLE and SQLite (#12848)

Browse Source 
* Added NotSupportedException when using Alter Table and SQLite. This is considered better than the underlying sql error.

* use Environment.NewLine
This commit is contained in:
Bjarke Berg
2022-08-22 15:48:17 +02:00
committed by GitHub
parent f8e20a9db9
commit d96c9a77cf
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Umbraco.Infrastructure/Migrations/Expressions/Alter/Table/AlterTableBuilder.cs
View File

@@ -2,6 +2,7 @@ using System.Data;
using Umbraco.Cms.Infrastructure.Migrations.Expressions.Alter.Expressions;
using Umbraco.Cms.Infrastructure.Migrations.Expressions.Common.Expressions;
using Umbraco.Cms.Infrastructure.Migrations.Expressions.Create.Expressions;
using Umbraco.Cms.Infrastructure.Persistence;
using Umbraco.Cms.Infrastructure.Persistence.DatabaseAnnotations;
using Umbraco.Cms.Infrastructure.Persistence.DatabaseModelDefinitions;
@@ -21,7 +22,14 @@ public class AlterTableBuilder : ExpressionBuilderBase<AlterTableExpression, IAl
public ForeignKeyDefinition CurrentForeignKey { get; set; } = null!;
public void Do() => Expression.Execute();
public void Do()
{
if (_context.Database.DatabaseType.IsSqlite())
{
throw new NotSupportedException($"SQLite do not support ALTER TABLE operations.Instead you will have to:{Environment.NewLine}1. Create a temp table.{Environment.NewLine}2. Copy data from existing table into temp table.{Environment.NewLine}3. Delete existing table.{Environment.NewLine}4. Create new table with existing name but new signature{Environment.NewLine}5. Copy data from temp table into the new table.{Environment.NewLine}6. Delete temp table.");
}
Expression.Execute();
}
public IAlterTableColumnOptionBuilder WithDefault(SystemMethods method)
{