yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RadioButtonList: prevent double 'change' event

Browse Source 
Both the `uui-radio-group` and `uui-radio` dispatch a 'change' event,
which triggers the `#onChange` method twice.

The `uui-radio` component is the one that contains the changed value,
so updated the code to only use that.
This commit is contained in:
leekelleher
2024-04-18 09:42:53 +01:00
parent 79ad702cc3
commit de9ff096d4
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Umbraco.Web.UI.Client/src/packages/core/components/input-radio-button-list/input-radio-button-list.element.ts
View File

@@ -1,8 +1,8 @@
import { css, html, nothing, repeat, customElement, property } from '@umbraco-cms/backoffice/external/lit';
import { UUIFormControlMixin } from '@umbraco-cms/backoffice/external/uui';
import { UUIFormControlMixin, UUIRadioElement } from '@umbraco-cms/backoffice/external/uui';
import { UmbChangeEvent } from '@umbraco-cms/backoffice/event';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import type { UUIBooleanInputEvent } from '@umbraco-cms/backoffice/external/uui';
import type { UUIRadioEvent } from '@umbraco-cms/backoffice/external/uui';
@customElement('umb-input-radio-button-list')
export class UmbInputRadioButtonListElement extends UUIFormControlMixin(UmbLitElement, '') {
@@ -23,11 +23,10 @@ export class UmbInputRadioButtonListElement extends UUIFormControlMixin(UmbLitEl
return undefined;
}
#onChange(event: UUIBooleanInputEvent) {
#onChange(event: UUIRadioEvent) {
event.stopPropagation();
if (!(event.target instanceof UUIRadioElement)) return;
this.value = event.target.value;
this.dispatchEvent(new UmbChangeEvent());
}
@@ -46,7 +45,7 @@ export class UmbInputRadioButtonListElement extends UUIFormControlMixin(UmbLitEl
}
#renderRadioButton(item: (typeof this.list)[0]) {
return html`<uui-radio value="${item.value}" label="${item.label}"></uui-radio>`;
return html`<uui-radio value=${item.value} label=${item.label}></uui-radio>`;
}
static styles = [