annoying comments

This commit is contained in:
Niels Lyngsø
2022-05-24 13:48:45 +02:00
parent 7a9a5ba537
commit e18f9091df
4 changed files with 7 additions and 0 deletions

View File

@@ -11,6 +11,7 @@ export class UmbBackofficeMain extends LitElement {
flex: 1 1 auto;
}
// TODO: not call this editor, I would like to reserve that name for the view of editing data, like what goes in the router-outlet or in infinite editors (or inside Nested Content)
#editor {
background-color: var(--uui-color-background);
width: 100%;

View File

@@ -9,6 +9,8 @@ import { UmbContextInjectMixin } from '../core/context';
import { UmbExtensionManifest, UmbExtensionRegistry, UmbManifestSectionMeta } from '../core/extension';
import { UmbRouter } from '../core/router';
// TODO: umb or not umb in file name?
@customElement('umb-backoffice-header')
export class UmbBackofficeHeader extends UmbContextInjectMixin(LitElement) {
static styles: CSSResultGroup = [

View File

@@ -29,6 +29,9 @@ export class UmbBackoffice extends LitElement {
`,
];
// TODO: main div and then side and main again within? I propose the backoffice-main begin renamed to something less main-ish.
// TODO: I would think umb-backoffice-header would be outside the router outlet? so its always present.
render() {
return html`
<umb-backoffice-header></umb-backoffice-header>

View File

@@ -13,6 +13,7 @@ export function UmbContextProvideMixin<TBase extends Constructor>(Base: TBase) {
provide(contextKey: string, instance: any) {
if (this._providers.has(contextKey)) return;
this._providers.set(contextKey, new UmbContextProvider(this, contextKey, instance));
// TODO: if already connected then attach the new one.
}
connectedCallback() {