yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only encode text once

Browse Source 
Html.ReplaceLineBreaks calls WebUtility.HtmlEncode internally, so the text gets encoded by this method.

As far as I know, WebUtility.HtmlEncode and HttpUtility.HtmlEncode produces the same result (unlike WebUtility.UrlEncode and HttpUtility.UrlEncode which produces different results; see https://edi.wang/post/2018/11/25/netcore-webutility-urlencode-httputility-urlencode), so it should be safe to omit HttpUtility.HtmlEncode here.
This commit is contained in:
Kenny Nielsen
2021-08-12 15:59:55 +02:00
committed by Sebastiaan Janssen
parent 7710409be8
commit e4a2fc2736
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.Web.UI.NetCore/Views/Partials/grid/editors/textstring.cshtml
View File

@@ -4,7 +4,7 @@
@if (Model.editor.config.markup != null)
{
string markup = Model.editor.config.markup.ToString();
markup = markup.Replace("#value#", Html.ReplaceLineBreaks(HttpUtility.HtmlEncode((string)Model.value.ToString())).ToString());
markup = markup.Replace("#value#", Html.ReplaceLineBreaks((string)Model.value.ToString()).ToString());
if (Model.editor.config.style != null)
{